From: Ludek Finstrle <ludek.finstrle@pzkagis.cz>
To: linux-bluetooth@vger.kernel.org
Subject: obexd - bug in plugins irmc + phonebook-ebook
Date: Wed, 18 Jul 2012 10:47:55 +0200 [thread overview]
Message-ID: <20120718084754.GA6496@pzkagis.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
Hello,
I find the bug in IrMC + phonebook-ebook. There is function phonebook_pull defined in
phonebook-ebook. There is test for name '/telecom/pb.vcf' but IrMC plugin send name
only 'telecom/pb.vcf'.
I attached simple patch to correct this behaviour. To be honest I tested only
phonebook-ebook.
Best regards,
Luf
[-- Attachment #2: 204_fix_irmc_open_full_path.patch --]
[-- Type: text/plain, Size: 1379 bytes --]
diff -cr plugins/irmc.c plugins/irmc.c
*** plugins/irmc.c Thu May 17 11:12:17 2012
--- plugins/irmc.c Tue Jul 17 12:25:27 2012
***************
*** 226,232 ****
param->maxlistcount = 0; /* to count the number of vcards... */
param->filter = 0x200085; /* UID TEL N VERSION */
irmc->params = param;
! irmc->request = phonebook_pull("telecom/pb.vcf", irmc->params,
phonebook_size_result, irmc, err);
ret = phonebook_pull_read(irmc->request);
if (err)
--- 226,232 ----
param->maxlistcount = 0; /* to count the number of vcards... */
param->filter = 0x200085; /* UID TEL N VERSION */
irmc->params = param;
! irmc->request = phonebook_pull("/telecom/pb.vcf", irmc->params,
phonebook_size_result, irmc, err);
ret = phonebook_pull_read(irmc->request);
if (err)
***************
*** 312,318 ****
if (!g_strcmp0(name, ".vcf")) {
/* how can we tell if the vcard count call already finished? */
! irmc->request = phonebook_pull("telecom/pb.vcf", irmc->params,
query_result, irmc, &ret);
if (ret < 0) {
DBG("phonebook_pull failed...");
--- 312,318 ----
if (!g_strcmp0(name, ".vcf")) {
/* how can we tell if the vcard count call already finished? */
! irmc->request = phonebook_pull("/telecom/pb.vcf", irmc->params,
query_result, irmc, &ret);
if (ret < 0) {
DBG("phonebook_pull failed...");
reply other threads:[~2012-07-18 8:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718084754.GA6496@pzkagis.cz \
--to=ludek.finstrle@pzkagis.cz \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).