From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Frédéric Danis" <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v13 12/14] audio: Add DUN GW to org.bluez.Telephony
Date: Wed, 18 Jul 2012 14:58:01 +0300 [thread overview]
Message-ID: <20120718115801.GC15775@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1342532440-730-13-git-send-email-frederic.danis@linux.intel.com>
Hi Frédéric,
On Tue, Jul 17, 2012, Frédéric Danis wrote:
> +static void client_connect_cb(GIOChannel *chan, GError *err,
> + gpointer user_data)
> +{
> + struct tel_client *client = user_data;
> + char hs_address[18];
> +
> + if (err) {
> + error("%s", err->message);
> + goto done;
> + }
> +
> + ba2str(&client->dst, hs_address);
> +
> + telephony_device_connecting(chan, client->btd_dev, client,
> + client->agent);
Firstly, you've got the wrong indentation above. Only tabs please.
Secondly, this is exactly the kind of crap that happens when you start
using void * everywhere instead of proper types. The function
telephony_device_connecting casts the third parameter ("client" above)
to struct audio_device. See the problem?
Johan
next prev parent reply other threads:[~2012-07-18 11:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 13:40 [PATCH v13 00/14] Add org.bluez.Telephony interface Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 01/14] doc: Add telephony interface documents Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 02/14] audio: Move telephony drivers to D-Bus interface Frédéric Danis
2012-07-18 11:51 ` Johan Hedberg
2012-07-17 13:40 ` [PATCH v13 03/14] audio: Simplify org.bluez.Headset Frédéric Danis
2012-07-18 12:02 ` Johan Hedberg
2012-07-17 13:40 ` [PATCH v13 04/14] audio: Remove dummy telephony driver Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 05/14] audio: Remove maemo5 " Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 06/14] audio: Remove maemo6 " Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 07/14] audio: Remove oFono " Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 08/14] audio: Move HFP/HSP AG servers to telephony.c Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 09/14] audio: Send transport path to telephony agent Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 10/14] audio: Move HFP HF server to telephony.c Frédéric Danis
2012-07-18 11:54 ` Johan Hedberg
2012-07-17 13:40 ` [PATCH v13 11/14] audio: Replace headset and gateway by telephony Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 12/14] audio: Add DUN GW to org.bluez.Telephony Frédéric Danis
2012-07-18 11:58 ` Johan Hedberg [this message]
2012-07-17 13:40 ` [PATCH v13 13/14] audio: Add SAP " Frédéric Danis
2012-07-17 13:40 ` [PATCH v13 14/14] audio: Add fast connectable to telephony interface Frédéric Danis
2012-07-18 11:59 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718115801.GC15775@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).