From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
Date: Tue, 24 Jul 2012 11:54:49 +0200
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: Claudio Takahasi <claudio.takahasi@openbossa.org>,
	linux-bluetooth@vger.kernel.org,
	Paulo Alcantara <paulo.alcantara@openbossa.org>
Subject: Re: [PATCH BlueZ] btio: Rescue lost errorneous numbers
Message-ID: <20120724095449.GD9576@x220.ice.intel.com>
References: <1343054163-19119-1-git-send-email-claudio.takahasi@openbossa.org>
 <1343054163-19119-2-git-send-email-claudio.takahasi@openbossa.org>
 <CAJdJm_N7Z4a2p7-Ur+_kEf2Q==aL5QTYpmnRomX+LXjy1Dd37Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <CAJdJm_N7Z4a2p7-Ur+_kEf2Q==aL5QTYpmnRomX+LXjy1Dd37Q@mail.gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Lizardo,

On Mon, Jul 23, 2012, Anderson Lizardo wrote:
> On Mon, Jul 23, 2012 at 10:36 AM, Claudio Takahasi
> <claudio.takahasi@openbossa.org> wrote:
> >  #define ERROR_FAILED(gerr, str, err) \
> > -               g_set_error(gerr, BT_IO_ERROR, BT_IO_ERROR_FAILED, \
> > +               g_set_error(gerr, BT_IO_ERROR, err, \
> >                                 str ": %s (%d)", strerror(err), err)
> > [...]
> >                 if (err < 0)
> > -                       g_set_error(&gerr, BT_IO_ERROR,
> > -                                       BT_IO_ERROR_CONNECT_FAILED, "%s (%d)",
> > -                                       strerror(-err), -err);
> > -       } else if (cond & (G_IO_HUP | G_IO_ERR))
> > -               g_set_error(&gerr, BT_IO_ERROR, BT_IO_ERROR_CONNECT_FAILED,
> > -                               "HUP or ERR on socket");
> > +                       g_set_error(&gerr, BT_IO_ERROR, -err, "%s (%d)",
> > +                                                       strerror(-err), -err);
> 
> why not use the ERROR_FAILED() macro here?
> 
> >         if (err < 0) {
> > -               g_set_error(gerr, BT_IO_ERROR, BT_IO_ERROR_CONNECT_FAILED,
> > -                               "connect: %s (%d)", strerror(-err), -err);
> > +               g_set_error(gerr, BT_IO_ERROR, -err, "connect: %s (%d)",
> > +                                                       strerror(-err), -err);
> 
> and here?

Good point. Unfortunately I didn't notice this before applying so please
(Claudio) send a fix on top of your patch.

Johan