From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jefferson Delfes <jefferson.delfes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 4/5] Bluetooth: Add set broadcaster MGMT command
Date: Tue, 14 Aug 2012 12:13:17 +0300 [thread overview]
Message-ID: <20120814091317.GA1083@x220> (raw)
In-Reply-To: <1344632507-21381-5-git-send-email-jefferson.delfes@openbossa.org>
Hi Jefferson,
On Fri, Aug 10, 2012, Jefferson Delfes wrote:
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -379,6 +379,7 @@ static u32 get_supported_settings(struct hci_dev *hdev)
> settings |= MGMT_SETTING_FAST_CONNECTABLE;
> settings |= MGMT_SETTING_DISCOVERABLE;
> settings |= MGMT_SETTING_PAIRABLE;
> + settings |= MGMT_SETTING_BROADCASTER;
Shouldn't this be behind the same conditional as MGMT_SETTING_LE? I.e.
only when hdev->features indicates LE support.
Johan
next prev parent reply other threads:[~2012-08-14 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 21:01 [RFC 0/5] Broadcaster/Observer MGMT API Jefferson Delfes
2012-08-10 21:01 ` [RFC 1/5] Bluetooth: Add new commands HCI for LE and BR/EDR Jefferson Delfes
2012-08-10 21:01 ` [RFC 2/5] Bluetooth: Add set controller data MGMT command Jefferson Delfes
2012-08-10 21:01 ` [RFC 3/5] Bluetooth: Add unset " Jefferson Delfes
2012-08-10 21:01 ` [RFC 4/5] Bluetooth: Add set broadcaster " Jefferson Delfes
2012-08-14 9:13 ` Johan Hedberg [this message]
2012-08-29 17:42 ` Aloisio Almeida
2012-08-10 21:01 ` [RFC 5/5] Bluetooth: Add set observer " Jefferson Delfes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814091317.GA1083@x220 \
--to=johan.hedberg@gmail.com \
--cc=jefferson.delfes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).