From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: Gustavo Padovan <gustavo@padovan.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv1 4/4] Bluetooth: trivial: Use preferred method for NULL check
Date: Wed, 15 Aug 2012 12:57:23 +0300 [thread overview]
Message-ID: <20120815095721.GA5154@aemeltch-MOBL1> (raw)
In-Reply-To: <20120815041655.GD3344@joana>
Hi Gustavo,
On Wed, Aug 15, 2012 at 01:16:55AM -0300, Gustavo Padovan wrote:
> > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> >
> > Use standard bluetooth way to check NULL pointer !var instead of
> > var == NULL.
> >
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > ---
> > net/bluetooth/af_bluetooth.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I applied patches 2, 3 and 4 to bluetooth-next. Patch 1 needs rebase. Thanks.
Patches 1 and 3 needs patch from linux-next and wireless-testing
<------8<------------------------------------------------------------------
| vsprintf: add %pMR for Bluetooth MAC address
|
| author Andrei Emeltchenko <andrei.emeltchenko@intel.com>
| Mon, 30 Jul 2012 21:40:23 +0000 (14:40 -0700)
| committer Linus Torvalds <torvalds@linux-foundation.org>
| Tue, 31 Jul 2012 00:25:14 +0000 (17:25 -0700)
| Bluetooth uses mostly LE byte order which is reversed for visual
| interpretation. Currently in Bluetooth in use unsafe batostr function.
|
| This is a slightly modified version of Joe's patch (sent Sat, Dec 4,
| 2010).
|
| Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
| Cc: Joe Perches <joe@perches.com>
| Cc: Marcel Holtmann <marcel@holtmann.org>
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
<------8<------------------------------------------------------------------
which adds actual specifier.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-08-15 9:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 15:05 [PATCHv1 0/4] Remove unsafe batostr Andrei Emeltchenko
2012-08-07 15:05 ` [PATCHv1 1/4] Bluetooth: Use %pMR BT addr print spec instead of batostr Andrei Emeltchenko
2012-08-07 15:05 ` [PATCHv1 2/4] Bluetooth: trivial: Shorten variable scope Andrei Emeltchenko
2012-08-07 15:05 ` [PATCHv1 3/4] Bluetooth: Use %pMR instead of baswap in seq_show Andrei Emeltchenko
2012-08-07 15:05 ` [PATCHv1 4/4] Bluetooth: trivial: Use preferred method for NULL check Andrei Emeltchenko
2012-08-15 4:16 ` Gustavo Padovan
2012-08-15 9:57 ` Andrei Emeltchenko [this message]
2012-08-21 17:55 ` Gustavo Padovan
2012-09-25 9:49 ` [PATCHv2 0/4] Remove unsafe batostr Andrei Emeltchenko
2012-09-25 9:49 ` [PATCHv2 1/4] Bluetooth: Use %pMR in debug instead of batostr Andrei Emeltchenko
2012-09-25 9:49 ` [PATCHv2 2/4] Bluetooth: Use %pMR in sprintf/seq_printf " Andrei Emeltchenko
2012-09-25 9:49 ` [PATCHv2 3/4] Bluetooth: Use %pMR instead of baswap in seq_show Andrei Emeltchenko
2012-09-25 9:49 ` [PATCHv2 4/4] bluetooth: Remove unneeded batostr function Andrei Emeltchenko
2012-09-25 16:27 ` [PATCHv2 0/4] Remove unsafe batostr Marcel Holtmann
2012-09-27 21:11 ` Gustavo Padovan
2012-08-07 15:45 ` [PATCHv1 " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815095721.GA5154@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox