* [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
@ 2012-08-12 7:41 aborigines
2012-08-12 15:35 ` Marcel Holtmann
2012-08-15 4:41 ` Gustavo Padovan
0 siblings, 2 replies; 7+ messages in thread
From: aborigines @ 2012-08-12 7:41 UTC (permalink / raw)
To: marcel, padovan; +Cc: linux-bluetooth, linux-kernel, aborigines
$ usb-deveices
T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#= 5 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0489 ProdID=e046 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=C01885F67F9E
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
$ lsusb
Bus 001 Device 005: ID 0489:e046 Foxconn / Hon Hai
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fc4bcd6..fb54c70 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -110,6 +110,7 @@ static struct usb_device_id btusb_table[] = {
/* Foxconn - Hon Hai */
{ USB_DEVICE(0x0489, 0xe033) },
+ { USB_DEVICE(0x0489, 0xe046) },
{ } /* Terminating entry */
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
2012-08-12 7:41 [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai aborigines
@ 2012-08-12 15:35 ` Marcel Holtmann
2012-08-12 16:22 ` koko Aborigines
2012-08-15 4:41 ` Gustavo Padovan
1 sibling, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2012-08-12 15:35 UTC (permalink / raw)
To: aborigines; +Cc: padovan, linux-bluetooth, linux-kernel
Hi,
> $ usb-deveices
> T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#= 5 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0489 ProdID=e046 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=C01885F67F9E
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> $ lsusb
> Bus 001 Device 005: ID 0489:e046 Foxconn / Hon Hai
you need a Signed-off-by here.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
2012-08-12 15:35 ` Marcel Holtmann
@ 2012-08-12 16:22 ` koko Aborigines
0 siblings, 0 replies; 7+ messages in thread
From: koko Aborigines @ 2012-08-12 16:22 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: padovan, linux-bluetooth, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Hi,
Sorry for my mistake.
Signed-off-by: Watcharapol Tadtiang <7aborigines7@gmail.com>
Thank You.
On Sun, Aug 12, 2012 at 10:35 PM, Marcel Holtmann <marcel@holtmann.org>wrote:
> Hi,
>
> > $ usb-deveices
> > T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#= 5 Spd=12 MxCh= 0
> > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> > P: Vendor=0489 ProdID=e046 Rev=01.12
> > S: Manufacturer=Broadcom Corp
> > S: Product=BCM20702A0
> > S: SerialNumber=C01885F67F9E
> > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> >
> > $ lsusb
> > Bus 001 Device 005: ID 0489:e046 Foxconn / Hon Hai
>
> you need a Signed-off-by here.
>
> Regards
>
> Marcel
>
>
>
[-- Attachment #2: Type: text/html, Size: 1598 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
2012-08-12 7:41 [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai aborigines
2012-08-12 15:35 ` Marcel Holtmann
@ 2012-08-15 4:41 ` Gustavo Padovan
2012-08-16 3:12 ` koko Aborigines
1 sibling, 1 reply; 7+ messages in thread
From: Gustavo Padovan @ 2012-08-15 4:41 UTC (permalink / raw)
To: aborigines; +Cc: marcel, padovan, linux-bluetooth, linux-kernel
* aborigines <7aborigines7@gmail.com> [2012-08-12 14:41:44 +0700]:
> $ usb-deveices
> T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#= 5 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0489 ProdID=e046 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=C01885F67F9E
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> $ lsusb
> Bus 001 Device 005: ID 0489:e046 Foxconn / Hon Hai
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fc4bcd6..fb54c70 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -110,6 +110,7 @@ static struct usb_device_id btusb_table[] = {
>
> /* Foxconn - Hon Hai */
> { USB_DEVICE(0x0489, 0xe033) },
> + { USB_DEVICE(0x0489, 0xe046) },
>
> { } /* Terminating entry */
> };
Can you try the following patch and see if it works for you.
Gustavo
---
commit 8d2952f43af434f0aa5d109a9ae50c5886a9322c (HEAD, master)
Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Date: Wed Aug 15 01:38:11 2012 -0300
Bluetooth: Add USB_VENDOR_AND_INTERFACE_INFO() for Broadcom/Foxconn
Foxconn devices has a vendor specific class of device, we will match them
differently now.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f637c25..f077f4d 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -101,7 +101,7 @@ static struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x413c, 0x8197) },
/* Foxconn - Hon Hai */
- { USB_DEVICE(0x0489, 0xe033) },
+ { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01) },
{ } /* Terminating entry */
};
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
2012-08-15 4:41 ` Gustavo Padovan
@ 2012-08-16 3:12 ` koko Aborigines
2012-08-16 5:10 ` Gustavo Padovan
0 siblings, 1 reply; 7+ messages in thread
From: koko Aborigines @ 2012-08-16 3:12 UTC (permalink / raw)
To: Gustavo Padovan, aborigines, marcel, padovan, linux-bluetooth,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2870 bytes --]
Hi, Gustavo
i have error with your patch
CC [M] drivers/bluetooth/btusb.o
drivers/bluetooth/btusb.c:113:2: error: implicit declaration of function
‘USB_VENDOR_AND_INTERFACE_INFO’ [-Werror=implicit-function-declaration]
drivers/bluetooth/btusb.c:113:2: error: initializer element is not constant
drivers/bluetooth/btusb.c:113:2: error: (near initialization for
‘btusb_table[22].match_flags’)
System : Debian Wheezy amd64
Thanks.
On Wed, Aug 15, 2012 at 11:41 AM, Gustavo Padovan <gustavo@padovan.org>wrote:
> * aborigines <7aborigines7@gmail.com> [2012-08-12 14:41:44 +0700]:
>
> > $ usb-deveices
> > T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#= 5 Spd=12 MxCh= 0
> > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> > P: Vendor=0489 ProdID=e046 Rev=01.12
> > S: Manufacturer=Broadcom Corp
> > S: Product=BCM20702A0
> > S: SerialNumber=C01885F67F9E
> > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> >
> > $ lsusb
> > Bus 001 Device 005: ID 0489:e046 Foxconn / Hon Hai
> > ---
> > drivers/bluetooth/btusb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index fc4bcd6..fb54c70 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -110,6 +110,7 @@ static struct usb_device_id btusb_table[] = {
> >
> > /* Foxconn - Hon Hai */
> > { USB_DEVICE(0x0489, 0xe033) },
> > + { USB_DEVICE(0x0489, 0xe046) },
> >
> > { } /* Terminating entry */
> > };
>
> Can you try the following patch and see if it works for you.
>
> Gustavo
>
> ---
> commit 8d2952f43af434f0aa5d109a9ae50c5886a9322c (HEAD, master)
> Author: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Date: Wed Aug 15 01:38:11 2012 -0300
>
> Bluetooth: Add USB_VENDOR_AND_INTERFACE_INFO() for Broadcom/Foxconn
>
> Foxconn devices has a vendor specific class of device, we will match
> them
> differently now.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index f637c25..f077f4d 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -101,7 +101,7 @@ static struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x413c, 0x8197) },
>
> /* Foxconn - Hon Hai */
> - { USB_DEVICE(0x0489, 0xe033) },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xff, 0x01, 0x01) },
>
> { } /* Terminating entry */
> };
>
>
[-- Attachment #2: Type: text/html, Size: 3650 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
2012-08-16 3:12 ` koko Aborigines
@ 2012-08-16 5:10 ` Gustavo Padovan
2012-10-25 0:57 ` koko Aborigines
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo Padovan @ 2012-08-16 5:10 UTC (permalink / raw)
To: koko Aborigines; +Cc: marcel, padovan, linux-bluetooth, linux-kernel
Hi,
* koko Aborigines <7aborigines7@gmail.com> [2012-08-16 10:12:44 +0700]:
> Hi, Gustavo
>=20
> i have error with your patch
>=20
> CC [M] drivers/bluetooth/btusb.o
> drivers/bluetooth/btusb.c:113:2: error: implicit declaration of function
> =E2=80=98USB_VENDOR_AND_INTERFACE_INFO=E2=80=99 [-Werror=3Dimplicit-funct=
ion-declaration]
> drivers/bluetooth/btusb.c:113:2: error: initializer element is not consta=
nt
> drivers/bluetooth/btusb.c:113:2: error: (near initialization for
> =E2=80=98btusb_table[22].match_flags=E2=80=99)
You need to apply it against the bluetooth-next tree (or linux-next).
Gustavo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai
2012-08-16 5:10 ` Gustavo Padovan
@ 2012-10-25 0:57 ` koko Aborigines
0 siblings, 0 replies; 7+ messages in thread
From: koko Aborigines @ 2012-10-25 0:57 UTC (permalink / raw)
To: Gustavo Padovan, koko Aborigines, marcel, padovan,
linux-bluetooth, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
Hi,
On ubuntu 12.10 Base Kernel 3.5.5
Your Patch is work
Thank You.
ref https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1030233
On Thu, Aug 16, 2012 at 12:10 PM, Gustavo Padovan <gustavo@padovan.org>wrote:
> Hi,
>
> * koko Aborigines <7aborigines7@gmail.com> [2012-08-16 10:12:44 +0700]:
>
> > Hi, Gustavo
> >
> > i have error with your patch
> >
> > CC [M] drivers/bluetooth/btusb.o
> > drivers/bluetooth/btusb.c:113:2: error: implicit declaration of function
> > ‘USB_VENDOR_AND_INTERFACE_INFO’ [-Werror=implicit-function-declaration]
> > drivers/bluetooth/btusb.c:113:2: error: initializer element is not
> constant
> > drivers/bluetooth/btusb.c:113:2: error: (near initialization for
> > ‘btusb_table[22].match_flags’)
>
> You need to apply it against the bluetooth-next tree (or linux-next).
>
> Gustavo
>
[-- Attachment #2: Type: text/html, Size: 1406 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-25 0:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-12 7:41 [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai aborigines
2012-08-12 15:35 ` Marcel Holtmann
2012-08-12 16:22 ` koko Aborigines
2012-08-15 4:41 ` Gustavo Padovan
2012-08-16 3:12 ` koko Aborigines
2012-08-16 5:10 ` Gustavo Padovan
2012-10-25 0:57 ` koko Aborigines
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).