From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 5/7] Bluetooth: Refactor SCO connection into its own function
Date: Thu, 16 Aug 2012 10:14:16 +0300 [thread overview]
Message-ID: <20120816071414.GA24160@aemeltch-MOBL1> (raw)
In-Reply-To: <1343428380-32705-6-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Fri, Jul 27, 2012 at 07:32:58PM -0300, Vinicius Costa Gomes wrote:
...
> -/* Create SCO, ACL or LE connection.
> - * Device _must_ be locked */
> -struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst,
> - __u8 dst_type, __u8 sec_level, __u8 auth_type)
> +static struct hci_conn *hci_connect_sco(struct hci_dev *hdev, bdaddr_t *dst,
> + u8 sec_level, u8 auth_type)
Here we use u8
...
> +/* Create SCO, ACL or LE connection. */
> +struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst,
> + __u8 dst_type, __u8 sec_level, __u8 auth_type
...
and here __u8
Shall we agree about those type usage, I thought that we use __u* in
headers and u* in c-files. At least in one file we shall use one type.
Best regards
Andrei Emeltchenko
next prev parent reply other threads:[~2012-08-16 7:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 22:32 [PATCH v3 0/7] Bluetooth: Refactoring hci_connect() Vinicius Costa Gomes
2012-07-27 22:32 ` [PATCH v3 1/7] Bluetooth: Remove some functions from being exported Vinicius Costa Gomes
2012-07-27 22:32 ` [PATCH v3 2/7] Bluetooth: Rename LE and ACL connection functions Vinicius Costa Gomes
2012-07-27 22:32 ` [PATCH v3 3/7] Bluetooth: Refactor LE connection into its own function Vinicius Costa Gomes
2012-07-27 22:32 ` [PATCH v3 4/7] Bluetooth: Refactor ACL " Vinicius Costa Gomes
2012-07-27 22:52 ` Anderson Lizardo
2012-07-27 22:55 ` Anderson Lizardo
2012-07-29 0:13 ` Vinicius Costa Gomes
2012-07-29 1:35 ` [PATCH v4 " Vinicius Costa Gomes
2012-07-27 22:32 ` [PATCH v3 5/7] Bluetooth: Refactor SCO " Vinicius Costa Gomes
2012-08-16 7:14 ` Andrei Emeltchenko [this message]
2012-07-27 22:32 ` [PATCH v3 6/7] Bluetooth: Simplify a the connection type handling Vinicius Costa Gomes
2012-07-27 22:33 ` [PATCH v3 7/7] Bluetooth: Add type information to the hci_connect() debug statement Vinicius Costa Gomes
2012-08-15 4:04 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816071414.GA24160@aemeltch-MOBL1 \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox