* [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete
@ 2012-08-15 21:13 Andre Guedes
2012-08-15 21:14 ` [PATCH BlueZ 2/2] mgmt: Fix Set SSP " Andre Guedes
2012-08-16 7:36 ` [PATCH BlueZ 1/2] mgmt: Fix Set LE " Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Andre Guedes @ 2012-08-15 21:13 UTC (permalink / raw)
To: linux-bluetooth
Once we get a Set LE command complete event, we should update
current_settings from the controller_info. Otherwise, features
which depend on that, such as device discovery, will not work
properly.
---
src/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mgmt.c b/src/mgmt.c
index b3ae776..fbd2a6b 100644
--- a/src/mgmt.c
+++ b/src/mgmt.c
@@ -1388,7 +1388,7 @@ static void mgmt_cmd_complete(int sk, uint16_t index, void *buf, size_t len)
DBG("set_ssp complete");
break;
case MGMT_OP_SET_LE:
- DBG("set_le complete");
+ mgmt_new_settings(sk, index, ev->data, len);
break;
case MGMT_OP_ADD_UUID:
mgmt_add_uuid_complete(sk, index, ev->data, len);
--
1.7.11.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH BlueZ 2/2] mgmt: Fix Set SSP command complete
2012-08-15 21:13 [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete Andre Guedes
@ 2012-08-15 21:14 ` Andre Guedes
2012-08-16 7:36 ` [PATCH BlueZ 1/2] mgmt: Fix Set LE " Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Andre Guedes @ 2012-08-15 21:14 UTC (permalink / raw)
To: linux-bluetooth
Once we get a Set SSP command complete event, we should update
current_settings from the controller_info. Otherwise, features
which depend on that will not work properly.
---
src/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mgmt.c b/src/mgmt.c
index fbd2a6b..94b2a04 100644
--- a/src/mgmt.c
+++ b/src/mgmt.c
@@ -1385,7 +1385,7 @@ static void mgmt_cmd_complete(int sk, uint16_t index, void *buf, size_t len)
mgmt_new_settings(sk, index, ev->data, len);
break;
case MGMT_OP_SET_SSP:
- DBG("set_ssp complete");
+ mgmt_new_settings(sk, index, ev->data, len);
break;
case MGMT_OP_SET_LE:
mgmt_new_settings(sk, index, ev->data, len);
--
1.7.11.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete
2012-08-15 21:13 [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete Andre Guedes
2012-08-15 21:14 ` [PATCH BlueZ 2/2] mgmt: Fix Set SSP " Andre Guedes
@ 2012-08-16 7:36 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2012-08-16 7:36 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
On Wed, Aug 15, 2012, Andre Guedes wrote:
> Once we get a Set LE command complete event, we should update
> current_settings from the controller_info. Otherwise, features
> which depend on that, such as device discovery, will not work
> properly.
> ---
> src/mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Both patches have been applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-16 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-15 21:13 [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete Andre Guedes
2012-08-15 21:14 ` [PATCH BlueZ 2/2] mgmt: Fix Set SSP " Andre Guedes
2012-08-16 7:36 ` [PATCH BlueZ 1/2] mgmt: Fix Set LE " Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).