From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 0/9] GObexApparam API
Date: Thu, 16 Aug 2012 12:43:05 +0300 [thread overview]
Message-ID: <20120816094305.GA3566@x220> (raw)
In-Reply-To: <1344508353-24647-1-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Thu, Aug 09, 2012, Luiz Augusto von Dentz wrote:
> GObexApparam can encode/decode OBEX application parameter in a generic
> way, only the tags are expecific to each profile.
>
> Some remarks:
>
> - Tag data is stored in network order/big endian because its type is
> not known.
> - Internally it uses a GHashTable to store the values which doesn't
> guarantee the order of the tag will be exact the same as inserted.
>
> Luiz Augusto von Dentz (9):
> gobex: Introduce GObexApparam API
> gobex: Add unit tests for GObexApparam API
> gobex: Integrate GObexApparam with GObexHeader
> gobex: Add unit test for encoding/decoding apparam headers
> gobex: Add debug option to apparam
> client: Port PBAP module to use GObexApparam
> PBAP: Make use of GObexApparam API
> MAP: Make use of GObexApparam API
> core: Remove map_ap.c
>
> Makefile.am | 18 +-
> client/pbap.c | 181 +++++-------------
> gobex/gobex-apparam.c | 355 +++++++++++++++++++++++++++++++++++
> gobex/gobex-apparam.h | 59 ++++++
> gobex/gobex-debug.h | 7 +-
> gobex/gobex-header.c | 25 +++
> gobex/gobex-header.h | 3 +
> gobex/gobex.c | 11 +-
> plugins/mas.c | 81 ++++----
> plugins/pbap.c | 180 ++++--------------
> plugins/phonebook.h | 2 +-
> src/map_ap.c | 466 ----------------------------------------------
> src/map_ap.h | 63 -------
> unit/test-gobex-apparam.c | 422 +++++++++++++++++++++++++++++++++++++++++
> unit/test-gobex-header.c | 46 +++++
> 15 files changed, 1058 insertions(+), 861 deletions(-)
> create mode 100644 gobex/gobex-apparam.c
> create mode 100644 gobex/gobex-apparam.h
> delete mode 100644 src/map_ap.c
> create mode 100644 unit/test-gobex-apparam.c
All patches in this set have been applied. Thanks.
Johan
prev parent reply other threads:[~2012-08-16 9:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 10:32 [PATCH obexd 0/9] GObexApparam API Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 1/9] gobex: Introduce " Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 2/9] gobex: Add unit tests for " Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 3/9] gobex: Integrate GObexApparam with GObexHeader Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 4/9] gobex: Add unit test for encoding/decoding apparam headers Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 5/9] gobex: Add debug option to apparam Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 6/9] client: Port PBAP module to use GObexApparam Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 7/9] PBAP: Make use of GObexApparam API Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 8/9] MAP: " Luiz Augusto von Dentz
2012-08-09 10:32 ` [PATCH obexd 9/9] core: Remove map_ap.c Luiz Augusto von Dentz
2012-08-16 9:43 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816094305.GA3566@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).