From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v1 00/10] GATT Plugin
Date: Fri, 17 Aug 2012 11:29:16 +0300 [thread overview]
Message-ID: <20120817082916.GB31481@x220> (raw)
In-Reply-To: <1345147991-31320-1-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Thu, Aug 16, 2012, Claudio Takahasi wrote:
> This patch series adds a new GATT based plugin for GAP and GATT service.
> The objective is cleanup: moving some GATT related operations from the
> device(core) to a GATT based plugin.
>
> This first part is related to GAP appearance characteristic. A second
> patch will be sent soon to manage Service Changed and GATT/ATT MTU.
>
> Claudio Takahasi (10):
> gatt: Add Generic Access/Attribute Profile plugin
> gatt: Add GAP/GATT device registration
> gatt: Add read Appearance characteristic
> gatt: Add storing Appearance
> core: Remove Appearance characteristic read
> gatt: Emit PropertyChanged for Appearance
> core: PropertyChanged signal for Icon/class
> core: PropertyChanged signal for Icon/Appearance
> gatt: Map Appearance value 0x0000 to "unknown"
> gatt: Don't store Appearance if value is "unknown"
>
> Makefile.am | 8 ++-
> profiles/gatt/gas.c | 179 +++++++++++++++++++++++++++++++++++++++++++++++
> profiles/gatt/gas.h | 25 +++++++
> profiles/gatt/main.c | 52 ++++++++++++++
> profiles/gatt/manager.c | 82 +++++++++++++++++++++
> profiles/gatt/manager.h | 24 ++++++
> src/dbus-common.c | 2 +
> src/device.c | 74 +++++--------------
> src/device.h | 1 +
> 9 files changed, 390 insertions(+), 57 deletions(-)
> create mode 100644 profiles/gatt/gas.c
> create mode 100644 profiles/gatt/gas.h
> create mode 100644 profiles/gatt/main.c
> create mode 100644 profiles/gatt/manager.c
> create mode 100644 profiles/gatt/manager.h
Besides the one comment I already sent about this patch set it looks
more or less ok to me. Would it also make sense to move the server-side
GAP functionality into this plugin?
Johan
next prev parent reply other threads:[~2012-08-17 8:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 14:19 [PATCH BlueZ v0 00/10] GAP Plugin Claudio Takahasi
2012-08-15 14:19 ` [PATCH BlueZ v0 01/10] gap: Add Generic Access Profile plugin skeleton Claudio Takahasi
2012-08-15 14:19 ` [PATCH BlueZ v0 02/10] gap: Add GAP device registration Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 03/10] gap: Add read Appearance characteristic Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 04/10] gap: Add storing Appearance Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 05/10] core: Remove Appearance characteristic read Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 06/10] gap: Emit PropertyChanged for Appearance Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 07/10] core: PropertyChanged signal for Icon/class Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 08/10] core: PropertyChanged signal for Icon/Appearance Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 09/10] gap: Map Appearance value 0x0000 to unknown Claudio Takahasi
2012-08-15 14:20 ` [PATCH BlueZ v0 10/10] gap: Don't store Appearance if value is "unknown" Claudio Takahasi
2012-08-16 12:53 ` [PATCH BlueZ v0 00/10] GAP Plugin Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 00/10] GATT Plugin Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 01/10] gatt: Add Generic Access/Attribute Profile plugin Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 02/10] gatt: Add GAP/GATT device registration Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 03/10] gatt: Add read Appearance characteristic Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 04/10] gatt: Add storing Appearance Claudio Takahasi
2012-08-17 8:28 ` Johan Hedberg
2012-08-17 14:00 ` Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 05/10] core: Remove Appearance characteristic read Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 06/10] gatt: Emit PropertyChanged for Appearance Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 07/10] core: PropertyChanged signal for Icon/class Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 08/10] core: PropertyChanged signal for Icon/Appearance Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 09/10] gatt: Map Appearance value 0x0000 to "unknown" Claudio Takahasi
2012-08-16 20:13 ` [PATCH BlueZ v1 10/10] gatt: Don't store Appearance if value is "unknown" Claudio Takahasi
2012-08-17 8:29 ` Johan Hedberg [this message]
2012-08-17 14:04 ` [PATCH BlueZ v1 00/10] GATT Plugin Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 " Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 01/10] gatt: Add Generic Access/Attribute Profile plugin Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 02/10] gatt: Add GAP/GATT device registration Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 03/10] core: Add device method to access "Appearance" Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 04/10] gatt: Add read Appearance characteristic Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 05/10] core: Remove Appearance characteristic read Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 06/10] gatt: Emit PropertyChanged for Appearance Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 07/10] core: PropertyChanged signal for Icon/class Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 08/10] core: PropertyChanged signal for Icon/Appearance Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 09/10] core: Add storing Appearance Claudio Takahasi
2012-08-17 14:43 ` [PATCH BlueZ v2 10/10] gatt: Map Appearance value 0x0000 to "unknown" Claudio Takahasi
2012-08-20 9:20 ` [PATCH BlueZ v2 00/10] GATT Plugin Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817082916.GB31481@x220 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).