linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file
@ 2012-08-07  5:07 Sachin Kamat
  2012-08-07  6:12 ` Marcel Holtmann
  2012-08-27 15:24 ` Gustavo Padovan
  0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2012-08-07  5:07 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: marcel, gustavo, johan.hedberg, raja_mani, sachin.kamat, patches

module_platform_driver() makes the code simpler by eliminating module_init
and module_exit calls.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
This patch is based on bluetooth-next tree and is compile tested.
---
 drivers/bluetooth/btwilink.c |   16 +---------------
 1 files changed, 1 insertions(+), 15 deletions(-)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index 4ad7b35..60abf59 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -358,21 +358,7 @@ static struct platform_driver btwilink_driver = {
 	},
 };
 
-/* ------- Module Init/Exit interfaces ------ */
-static int __init btwilink_init(void)
-{
-	BT_INFO("Bluetooth Driver for TI WiLink - Version %s", VERSION);
-
-	return platform_driver_register(&btwilink_driver);
-}
-
-static void __exit btwilink_exit(void)
-{
-	platform_driver_unregister(&btwilink_driver);
-}
-
-module_init(btwilink_init);
-module_exit(btwilink_exit);
+module_platform_driver(btwilink_driver);
 
 /* ------ Module Info ------ */
 
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file
  2012-08-07  5:07 [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file Sachin Kamat
@ 2012-08-07  6:12 ` Marcel Holtmann
  2012-08-23 15:16   ` Sachin Kamat
  2012-08-27 15:24 ` Gustavo Padovan
  1 sibling, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2012-08-07  6:12 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-bluetooth, gustavo, johan.hedberg, raja_mani, patches

Hi Sachin,

> module_platform_driver() makes the code simpler by eliminating module_init
> and module_exit calls.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> This patch is based on bluetooth-next tree and is compile tested.
> ---
>  drivers/bluetooth/btwilink.c |   16 +---------------
>  1 files changed, 1 insertions(+), 15 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file
  2012-08-07  6:12 ` Marcel Holtmann
@ 2012-08-23 15:16   ` Sachin Kamat
  0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2012-08-23 15:16 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth, gustavo

Hi Gustavo,

Looks like the following patch is missed out from your tree.



On 7 August 2012 11:42, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Sachin,
>
>> module_platform_driver() makes the code simpler by eliminating module_init
>> and module_exit calls.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> This patch is based on bluetooth-next tree and is compile tested.
>> ---
>>  drivers/bluetooth/btwilink.c |   16 +---------------
>>  1 files changed, 1 insertions(+), 15 deletions(-)
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
>
> Regards
>
> Marcel
>
>



-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file
  2012-08-07  5:07 [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file Sachin Kamat
  2012-08-07  6:12 ` Marcel Holtmann
@ 2012-08-27 15:24 ` Gustavo Padovan
  1 sibling, 0 replies; 4+ messages in thread
From: Gustavo Padovan @ 2012-08-27 15:24 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: linux-bluetooth, marcel, johan.hedberg, raja_mani, patches

Hi Sachin,

* Sachin Kamat <sachin.kamat@linaro.org> [2012-08-07 10:37:45 +0530]:

> module_platform_driver() makes the code simpler by eliminating module_init
> and module_exit calls.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> This patch is based on bluetooth-next tree and is compile tested.
> ---
>  drivers/bluetooth/btwilink.c |   16 +---------------
>  1 files changed, 1 insertions(+), 15 deletions(-)

Patch has been applied to bluetooth-next. Thanks.

	Gustavo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-08-27 15:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-07  5:07 [PATCH] Bluetooth: Use module_platform_driver() in btwilink.c file Sachin Kamat
2012-08-07  6:12 ` Marcel Holtmann
2012-08-23 15:16   ` Sachin Kamat
2012-08-27 15:24 ` Gustavo Padovan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).