linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: szymon.janc@tieto.com
Cc: linux-bluetooth@vger.kernel.org
Subject: re: Bluetooth: Use GFP_KERNEL in read_index_list
Date: Tue, 4 Sep 2012 19:21:37 +0300	[thread overview]
Message-ID: <20120904162137.GA11841@elgon.mountain> (raw)

Hello Szymon Janc,

The patch 7cfeb868eb85: "Bluetooth: Use GFP_KERNEL in
read_index_list" from Aug 31, 2012, leads to the following warning:
net/bluetooth/mgmt.c:343 read_index_list()
	 error: scheduling with locks held:  'read_lock:hci_dev_list_lock'

This patch should be reverted because we're not allowed to schedule
while holding the read lock.  The way to avoid these bugs in the future
is to test with CONFIG_DEBUG_ATOMIC_SLEEP=y.  It will give a big splat.

regards,
dan carpenter


             reply	other threads:[~2012-09-04 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 16:21 Dan Carpenter [this message]
2012-09-04 18:52 ` Bluetooth: Use GFP_KERNEL in read_index_list Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904162137.GA11841@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).