linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 05/14] thermometer: Update API document
Date: Fri, 28 Sep 2012 13:40:22 +0300	[thread overview]
Message-ID: <20120928104022.GB25415@x220> (raw)
In-Reply-To: <1348584763-22824-6-git-send-email-andrzej.kaczmarek@tieto.com>

Hi Andrzej,

On Tue, Sep 25, 2012, Andrzej Kaczmarek wrote:
> This patch updates Thermometer API document to reflect changes in
> Thermometer interface and introduction of ThermometerManager
> interface.
> ---
>  doc/thermometer-api.txt | 59 +++++++++++++++++++++++++------------------------
>  1 file changed, 30 insertions(+), 29 deletions(-)
> 
> diff --git a/doc/thermometer-api.txt b/doc/thermometer-api.txt
> index 2271270..b0b0fe2 100644
> --- a/doc/thermometer-api.txt
> +++ b/doc/thermometer-api.txt
> @@ -3,28 +3,14 @@ BlueZ D-Bus Thermometer API description
>  
>  	Santiago Carot-Nemesio <sancane@gmail.com>
>  
> -Health Thermometer Profile hierarchy
> -=====================================

Could you please fix minor formatting inconsistencies like the
underlines (====) being different length than the text above it.

> -Service		org.bluez
> -Interface	org.bluez.Thermometer
> -Object path	[variable prefix]/{hci0,hci1,...}/dev_XX_XX_XX_XX_XX_XX
> -
> -
> -Methods		void SetProperty(string name, variant value)
> -
> -			Changes the value of the specified property. Only
> -			read-write properties can be changed. On success
> -			this will emit a PropertyChanged signal.
> +Health Thermometer Manager hierarchy
> +============================
>  
> -			Possible Errors: org.bluez.Error.InvalidArguments
> +Service 	org.bluez

Theres some weird space-tab stuff going on with the line above please
fix.

Johan

  reply	other threads:[~2012-09-28 10:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 14:52 [PATCH 00/14] Thermometer watchers API change + fixes Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 01/14] thermometer: Store thermometer devices per-adapter Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 02/14] thermometer: Register ThermometerManager interface on adapter path Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 03/14] thermometer: Move watcher logic to adapter interface Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 04/14] thermometer: Include remote device information in MeasurementReceived Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 05/14] thermometer: Update API document Andrzej Kaczmarek
2012-09-28 10:40   ` Johan Hedberg [this message]
2012-09-25 14:52 ` [PATCH 06/14] thermometer: Update test script Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 07/14] thermometer: Reformat MeasurementReceived description Andrzej Kaczmarek
2012-09-28 10:43   ` Johan Hedberg
2012-09-28 11:09     ` Santiago Carot
2012-09-28 11:27       ` Johan Hedberg
2012-09-25 14:52 ` [PATCH 08/14] thermometer: Update driver naming style Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 09/14] thermometer: Add constant definition for watcher interface name Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 10/14] thermometer: Add common function to write characteristics CCC Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 11/14] thermometer: Refactor processing of measurement characteristic value Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 12/14] thermometer: Fix whitespace Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 13/14] thermometer: Fix indentation Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 14/14] thermometer: Fix missing braces Andrzej Kaczmarek
2012-09-25 15:21 ` [PATCH 00/14] Thermometer watchers API change + fixes Anderson Lizardo
2012-09-27 10:47   ` Andrzej Kaczmarek
2012-09-27 12:03     ` Anderson Lizardo
2012-10-01 11:44       ` Andrzej Kaczmarek
2012-10-01 11:51         ` Anderson Lizardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928104022.GB25415@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=andrzej.kaczmarek@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).