From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 07/14] thermometer: Reformat MeasurementReceived description
Date: Fri, 28 Sep 2012 13:43:18 +0300 [thread overview]
Message-ID: <20120928104318.GC25415@x220> (raw)
In-Reply-To: <1348584763-22824-8-git-send-email-andrzej.kaczmarek@tieto.com>
Hi Andrzej,
On Tue, Sep 25, 2012, Andrzej Kaczmarek wrote:
> + Measurement:
> +
> + int16 Exponent:
> + int32 Mantissa:
> +
> + Measurement value is calculated as
> + (Mantissa) x (10^Exponent)
> +
> + In case of invalid or missing data,
> + Exponent is set to 0 and Mantissa is
> + set to 2^23-1 (0x7FFFFF hexadecimal).
Why aren't we using the D-Bus DOUBLE type for this? For invalid/missing
data just leave out these values from the dict. No need to try to
brute-force a 1:1 mapping from the protocol to D-Bus.
> +
> + string Unit:
> +
> + Possible values: "Celsius" or "Fahrenheit"
String properties should be lower-case. Please fix (both doc and
implementation).
> + string Type (optional):
> +
> + Only present if measurement type is known.
> +
> + Possible values: "Armpit", "Body", "Ear",
> + "Finger", "Intestines", "Mouth",
> + "Rectum", "Toe", "Tympanum"
Same here.
> + string Measurement:
> +
> + Possible values: "Final" or "Intermediate"
And here.
Johan
next prev parent reply other threads:[~2012-09-28 10:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 14:52 [PATCH 00/14] Thermometer watchers API change + fixes Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 01/14] thermometer: Store thermometer devices per-adapter Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 02/14] thermometer: Register ThermometerManager interface on adapter path Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 03/14] thermometer: Move watcher logic to adapter interface Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 04/14] thermometer: Include remote device information in MeasurementReceived Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 05/14] thermometer: Update API document Andrzej Kaczmarek
2012-09-28 10:40 ` Johan Hedberg
2012-09-25 14:52 ` [PATCH 06/14] thermometer: Update test script Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 07/14] thermometer: Reformat MeasurementReceived description Andrzej Kaczmarek
2012-09-28 10:43 ` Johan Hedberg [this message]
2012-09-28 11:09 ` Santiago Carot
2012-09-28 11:27 ` Johan Hedberg
2012-09-25 14:52 ` [PATCH 08/14] thermometer: Update driver naming style Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 09/14] thermometer: Add constant definition for watcher interface name Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 10/14] thermometer: Add common function to write characteristics CCC Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 11/14] thermometer: Refactor processing of measurement characteristic value Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 12/14] thermometer: Fix whitespace Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 13/14] thermometer: Fix indentation Andrzej Kaczmarek
2012-09-25 14:52 ` [PATCH 14/14] thermometer: Fix missing braces Andrzej Kaczmarek
2012-09-25 15:21 ` [PATCH 00/14] Thermometer watchers API change + fixes Anderson Lizardo
2012-09-27 10:47 ` Andrzej Kaczmarek
2012-09-27 12:03 ` Anderson Lizardo
2012-10-01 11:44 ` Andrzej Kaczmarek
2012-10-01 11:51 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928104318.GC25415@x220 \
--to=johan.hedberg@gmail.com \
--cc=andrzej.kaczmarek@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).