From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 BlueZ 1/4] gatt: Add support for find included services
Date: Fri, 28 Sep 2012 14:08:33 +0300 [thread overview]
Message-ID: <20120928110833.GB14450@x220> (raw)
In-Reply-To: <1348526019-28402-2-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Mon, Sep 24, 2012, Vinicius Costa Gomes wrote:
> Some services like HID over LE can reference another service using
> included services.
>
> See Vol 3, Part G, section 2.6.3 of Core specification for more
> details.
> ---
> attrib/gatt.c | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> attrib/gatt.h | 9 +++
> 2 files changed, 203 insertions(+)
This one doesn't apply:
Applying: gatt: Add support for find included services
WARNING:LONG_LINE: line over 80 characters
#107: FILE: attrib/gatt.c:335:
+ resolve_included_uuid_cb, resolve, NULL);
Btw, if you guys are wondering why the stricter coding style checks,
I've added the following to .git/hooks/pre-{commit,applypatch}:
git diff --cached | ~/src/linux/scripts/checkpatch.pl --no-signoff --ignore INITIALISED_STATIC,NEW_TYPEDEFS,VOLATILE --show-types --mailback -
You might want to do the same (with the correct path to checkpatch.pl)).
And thanks to Luiz for the idea (he's using the same when applying
patches).
Johan
next prev parent reply other threads:[~2012-09-28 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 22:33 [PATCH v3 BlueZ 0/4] Support for GATT Find Included Vinicius Costa Gomes
2012-09-24 22:33 ` [PATCH v3 BlueZ 1/4] gatt: Add support for find included services Vinicius Costa Gomes
2012-09-28 11:08 ` Johan Hedberg [this message]
2012-09-28 11:28 ` Anderson Lizardo
2012-09-28 11:32 ` Johan Hedberg
2012-09-24 22:33 ` [PATCH v3 BlueZ 2/4] gatttool: Add "included" command Vinicius Costa Gomes
2012-09-24 22:33 ` [PATCH v3 BlueZ 3/4] core: Add support for included services Vinicius Costa Gomes
2012-09-24 22:33 ` [PATCH v3 BlueZ 4/4] attrib: Remove opcode parameter from g_attrib_send() Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928110833.GB14450@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).