linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Christian Cier-Zniewski <c.cier@gmx.de>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v8 00/13] Heart Rate Profile plugin
Date: Fri, 28 Sep 2012 16:59:21 +0300	[thread overview]
Message-ID: <20120928135921.GB6803@x220> (raw)
In-Reply-To: <20120928131647.GA4026@x220>

Hi,

On Fri, Sep 28, 2012, Johan Hedberg wrote:
> On Fri, Sep 28, 2012, Christian Cier-Zniewski wrote:
> > Hello Johan,
> > 
> > On 28.09.2012 12:25, Johan Hedberg wrote:
> > >   Heart Rate Profile (HRP) client API
> > >
> > >  Makefile.am                    |   9 +-
> > >
> > >All patches in this set have been applied. Thanks.
> > >
> > >
> > 
> > 
> > I had to apply the following patch to get the heart rate profile working.
> > It is currently missing in HEAD although it was present in the
> > patchset provided by Andrzej.
> > 
> > Christian
> > 
> > ---
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 3b37198..c27eb01 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -212,7 +212,7 @@ endif
> > 
> >  if GATTMODULES
> >  builtin_modules += thermometer alert time gatt_example proximity
> > deviceinfo \
> > -                       gatt scanparam
> > +                       gatt scanparam heartrate
> >  builtin_sources += profiles/thermometer/main.c \
> >                         profiles/thermometer/manager.h \
> >                         profiles/thermometer/manager.c \
> > 
> 
> The Makefile.am changes had conflicts because of other GATT profiles I
> applied earlier, so I had to completely manually fix this and probably
> made some mistake. Could you please send a proper git patch for this and
> I'll apply it?

Nevermind, I went ahead and fixed it myself.

Johan

  reply	other threads:[~2012-09-28 13:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 14:27 [PATCH v8 00/13] Heart Rate Profile plugin Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 01/13] Heart Rate Profile (HRP) client API Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 02/13] heartrate: Add initial HRP client support Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 03/13] heartrate: Add attio callbacks Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 04/13] heartrate: Discover HRS characteristics Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 05/13] heartrate: Discover Heart Rate Measurement CCC Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 06/13] heartrate: Read Body Sensor Location characteristics Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 07/13] heartrate: Add HeartRateManager interface Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 08/13] heartrate: Add support to enable notifications Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 09/13] heartrate: Process measurement notifications Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 10/13] heartrate: Add support to reset Energy Expended Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 11/13] heartrate: Add GetProperties method Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 12/13] heartrate: Add HeartRateWatcher interface to default policy Andrzej Kaczmarek
2012-09-25 14:27 ` [PATCH v8 13/13] heartrate: Add test script Andrzej Kaczmarek
2012-09-28 10:25 ` [PATCH v8 00/13] Heart Rate Profile plugin Johan Hedberg
2012-09-28 12:55   ` Christian Cier-Zniewski
2012-09-28 13:16     ` Johan Hedberg
2012-09-28 13:59       ` Johan Hedberg [this message]
2012-09-28 14:07       ` Christian Cier-Zniewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928135921.GB6803@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=c.cier@gmx.de \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).