From: Johan Hedberg <johan.hedberg@gmail.com>
To: Chen Ganir <chen.ganir@ti.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4 01/10] battery: Add generic device battery documentation
Date: Sun, 30 Sep 2012 13:56:21 +0300 [thread overview]
Message-ID: <20120930105621.GA30560@x220.Elisa> (raw)
In-Reply-To: <5067ED60.1080202@ti.com>
Hi Chen,
On Sun, Sep 30, 2012, Chen Ganir wrote:
> >On Mon, Sep 24, 2012, chen.ganir@ti.com wrote:
> >>+BlueZ D-Bus Battery API description
> >>+****************************************
> >
> >Please keep the "underline" consistent with the length of the text above
> >it.
> >
> >>+ Texas Instruments, Inc. <chen.ganir@ti.com>
> >
> >What's this supposed to be? If you want a copyright statement here then
> >make it of the proper format. Author info is not needed as we have the
> >AUTHORS file and the commit history.
> >
> Would you please specify what is the proper copyright message format
> ? doc/adapter-api.txt, doc/health-api.txt have two different styles.
> doc/oob-api.txt has a third style (AUTHOR <author@email> for
> COMPANY),
> doc/media-api.txt for example does not have any copyright
> information. In addition - you say author information is not
> required, yet all other copyright messages contain this. Is this a
> new policy ? If so, please specify the proper copyright message.
How about git grep "Texas Instruments"? None of the entries contain
author information so your assertion makes it look like you didn't
really dig too deep. The policy has always been to keep author info in
AUTHORS and the commit history and have copyright statements only for
the sake of copyright information. Exceptions do of course slip through
as the maintainers are humans and not robots ;)
Ultimately you need to ask your employer for what kind of copyright
statement you should use, e.g. some prefer to have a "All rights
reserved" at the end whereas others don't care.
> >>+ array{object} Batteries [readonly]
> >
> >I guess you should mark this with [experimental] since it'll be removed
> >with the advent of ObjectManager.
> >
> What is the difference between the Batteries property and the
> services or UUIDs property in device-api.txt ? Should all of them
> get marked with experimental ?
The Services property will probably be removed for 5.0 but the UUIDs
will stay (not sure why you brought it up anyway?). Just mark this new
property as experimental since it'll likely be gone by the time 5.0 goes
out.
Johan
next prev parent reply other threads:[~2012-09-30 10:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 7:15 [PATCH v4 00/10] Implement Generic battery and LE Battery client chen.ganir
2012-09-24 7:15 ` [PATCH v4 01/10] battery: Add generic device battery documentation chen.ganir
2012-09-28 10:59 ` Johan Hedberg
2012-09-30 6:57 ` Chen Ganir
2012-09-30 10:56 ` Johan Hedberg [this message]
2012-09-24 7:15 ` [PATCH v4 02/10] battery: Implement Generic device battery chen.ganir
2012-09-24 7:15 ` [PATCH v4 03/10] battery: Add GATT Battery Client Service skeleton chen.ganir
2012-09-24 7:15 ` [PATCH v4 04/10] battery: Add client connection logic chen.ganir
2012-09-24 7:15 ` [PATCH v4 05/10] battery: Discover Characteristic Descriptors chen.ganir
2012-09-24 7:15 ` [PATCH v4 06/10] battery: Get Battery ID chen.ganir
2012-09-24 7:15 ` [PATCH v4 07/10] battery: Add Battery to device chen.ganir
2012-09-24 7:15 ` [PATCH v4 08/10] battery: Read Battery level characteristic chen.ganir
2012-09-24 7:15 ` [PATCH v4 09/10] battery: Add support for notifications chen.ganir
2012-09-24 7:15 ` [PATCH v4 10/10] battery: Support persistent battery level chen.ganir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120930105621.GA30560@x220.Elisa \
--to=johan.hedberg@gmail.com \
--cc=chen.ganir@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).