Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 BlueZ 01/27] doc: Introduce Alert API
Date: Wed, 3 Oct 2012 11:21:18 +0300	[thread overview]
Message-ID: <20121003082118.GA12607@x220> (raw)
In-Reply-To: <1349209490-31830-2-git-send-email-anderson.lizardo@openbossa.org>

Hi Lizardo,

On Tue, Oct 02, 2012, Anderson Lizardo wrote:
> +		void SetRinger(string mode)
> +
> +			This method is only called if "ringer" alert category
> +			is specified when registering the agent.
> +
> +			Set ringer to the specified mode. If mode is "enabled",
> +			ringer is set to the default mode, as defined by the
> +			current active profile. If mode is "disabled", ringer
> +			will not activate on incoming calls, until it is set
> +			back to "enabled" mode.
> +
> +			Possible Errors: org.bluez.Error.InvalidArguments

Since you've used a string here instead of a boolean is it correct to
assume that you want to maintain the capability of extending the
possible values to more than just "enabled" and "disabled"? Does the
current profile/service specification already proved more possibilities
than these two values?

Johan

  reply	other threads:[~2012-10-03  8:21 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 18:00 [PATCH BlueZ 00/25] Add support for PASP and ANP server profiles Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 01/25] doc: Introduce Alert API Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 02/25] alert: Introduce manager abstraction layer Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 03/25] alert: Initial profile registration Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 04/25] alert: Add Phone Alert Status Service Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 05/25] alert: Add Ringer Control Point characteristic Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 06/25] alert: Add Ringer Setting characteristic Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 07/25] alert: Add Alert Status characteristic Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 08/25] alert: Initial Alert Notification Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 09/25] alert: Implement category registration in RegisterAlert() Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 10/25] alert: Add initial support for NewAlert D-Bus method Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 11/25] alert: Add initial support for UnreadAlert " Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 12/25] alert: Automatically unregister alert when agent leaves D-Bus Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 13/25] alert: Add per adapter attribute handle information Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 14/25] alert: Update Supported New/Unread Category characteristic values Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 15/25] alert: Update new alert characteristic value Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 16/25] alert: Update unread " Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 17/25] alert: Implement MuteOnce command Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 18/25] alert: Add support for calling MuteOnce() Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 19/25] alert: Add support for calling SetRinger() Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 20/25] alert: Add test-alert script Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 21/25] alert: Update Alert Status and Ringer Setting characteristic values Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 22/25] alert: Add support for ringer setting notification Anderson Lizardo
2012-09-24 18:00 ` [PATCH BlueZ 23/25] alert: Add support for alert status notification Anderson Lizardo
2012-09-24 18:01 ` [PATCH BlueZ 24/25] alert: Add support for new alert notification Anderson Lizardo
2012-09-24 18:01 ` [PATCH BlueZ 25/25] alert: Add support for unread " Anderson Lizardo
2012-09-27 18:36 ` [PATCH v2 BlueZ 00/27] Add support for PASP and ANP server profiles Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 01/27] doc: Introduce Alert API Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 02/27] alert: Introduce manager abstraction layer Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 03/27] alert: Initial profile registration Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 04/27] alert: Add Phone Alert Status Service Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 05/27] alert: Add Ringer Control Point characteristic Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 06/27] alert: Add Ringer Setting characteristic Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 07/27] alert: Add Alert Status characteristic Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 08/27] alert: Initial Alert Notification Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 09/27] alert: Implement category registration in RegisterAlert() Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 10/27] alert: Add initial support for NewAlert D-Bus method Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 11/27] alert: Add initial support for UnreadAlert " Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 12/27] alert: Automatically unregister alert when agent leaves D-Bus Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 13/27] alert: Add per adapter attribute handle information Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 14/27] alert: Update Supported New/Unread Category characteristic values Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 15/27] alert: Update new alert characteristic value Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 16/27] alert: Update unread " Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 17/27] alert: Implement MuteOnce command Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 18/27] alert: Add support for calling MuteOnce() Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 19/27] alert: Add support for calling SetRinger() Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 20/27] alert: Add test-alert script Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 21/27] alert: Update Alert Status and Ringer Setting characteristic values Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 22/27] alert: Add support for ringer setting notification Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 23/27] alert: Add support for alert status notification Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 24/27] alert: Add support for new alert notification Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 25/27] alert: Add support for unread " Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 26/27] alert: Implement Release() agent method Anderson Lizardo
2012-09-27 18:36   ` [PATCH v2 BlueZ 27/27] alert: Add org.bluez.AlertAgent to D-Bus policy file Anderson Lizardo
2012-10-02 20:24   ` [PATCH v3 BlueZ 00/27] Add support for PASP and ANP server profiles Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 01/27] doc: Introduce Alert API Anderson Lizardo
2012-10-03  8:21       ` Johan Hedberg [this message]
2012-10-03 10:56         ` Anderson Lizardo
2012-10-03 12:46       ` [PATCH v4 " Anderson Lizardo
2012-10-03 19:39         ` Johan Hedberg
2012-10-03 20:17           ` Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 02/27] alert: Introduce manager abstraction layer Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 03/27] alert: Initial profile registration Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 04/27] alert: Add Phone Alert Status Service Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 05/27] alert: Add Ringer Control Point characteristic Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 06/27] alert: Add Ringer Setting characteristic Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 07/27] alert: Add Alert Status characteristic Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 08/27] alert: Initial Alert Notification Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 09/27] alert: Implement category registration in RegisterAlert() Anderson Lizardo
2012-10-03 12:49       ` [PATCH v4 " Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 10/27] alert: Add initial support for NewAlert D-Bus method Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 11/27] alert: Add initial support for UnreadAlert " Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 12/27] alert: Automatically unregister alert when agent leaves D-Bus Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 13/27] alert: Add per adapter attribute handle information Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 14/27] alert: Update Supported New/Unread Category characteristic values Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 15/27] alert: Update new alert characteristic value Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 16/27] alert: Update unread " Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 17/27] alert: Implement MuteOnce command Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 18/27] alert: Add support for calling MuteOnce() Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 19/27] alert: Add support for calling SetRinger() Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 20/27] alert: Add test-alert script Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 21/27] alert: Update Alert Status and Ringer Setting characteristic values Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 22/27] alert: Add support for ringer setting notification Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 23/27] alert: Add support for alert status notification Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 24/27] alert: Add support for new alert notification Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 25/27] alert: Add support for unread " Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 26/27] alert: Implement Release() agent method Anderson Lizardo
2012-10-02 20:24     ` [PATCH v3 BlueZ 27/27] alert: Add org.bluez.AlertAgent to D-Bus policy file Anderson Lizardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121003082118.GA12607@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox