From: Johan Hedberg <johan.hedberg@gmail.com>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org,
Lucas De Marchi <lucas.de.marchi@gmail.com>
Subject: Re: [PATCH BlueZ v4 00/15] Properties + ObjectManager
Date: Thu, 4 Oct 2012 17:17:22 +0300 [thread overview]
Message-ID: <20121004141722.GA4173@x220> (raw)
In-Reply-To: <1349335599-12443-1-git-send-email-lucas.de.marchi@gmail.com>
Hi Lucas,
On Thu, Oct 04, 2012, Lucas De Marchi wrote:
> Here is a rebased version of the patches. Most notable change is on patch
> implementing the Set() method after feedback from Marcel. It doesn't cover the
> concerns from Luiz about checking privileges per-property since I think this
> could be added in a separate patch. As far as I could see the only user is
> MediaTransport interface. The most obvious way would be to add another hook in
> GDBusPropertyTable in order to check the privileges. Suggestions?
>
> First 2 patches could be applied nonetheles. Get and GetAll are well tested,
> both now and in the previous version of this patch set. Set() is still a
> bit raw - the users implementing it are very big (adapter, device) so
> they are not converted yet (previous patch doesn't apply anymore and there's a
> change in the API that requires them to be rewritten).
>
>
> Lucas De Marchi (10):
> gdbus: Move typedefs up
> gdbus: Use macros to add annotations
> gdbus: Add skeleton of DBus.Properties interface
> gdbus: Implement DBus.Properties.Get method
> gdbus: Implement DBus.Properties.GetAll method
> gdbus: Implement DBus.Properties.Set method
> gdbus: Add properties into Introspectable interface
> gdbus: Implement PropertiesChanged signal
> Use DBus.Properties on Control interface
> Use DBus.Properties on Manager interface
>
> Luiz Augusto von Dentz (5):
> gdbus: Add support for org.freedesktop.DBus.ObjectManager interface
> gdbus: Group interface changes to reduce the amount of signals
> emitted
> gdbus: Only export ObjectManager interface on root path
> gdbus: Integrates ObjectManager with Properties interface
> gdbus: Simplify code for appending properties
>
> audio/control.c | 57 ++--
> gdbus/gdbus.h | 74 +++--
> gdbus/object.c | 867 +++++++++++++++++++++++++++++++++++++++++++++++++++-----
> src/manager.c | 81 ++----
> 4 files changed, 897 insertions(+), 182 deletions(-)
This initial set has been applied. Now let's get testing it and fix any
pending issues that are found. Also please remember send the adapter and
device conversions when you've got them ready so that we get them stress
tested at the UPF next week.
Johan
next prev parent reply other threads:[~2012-10-04 14:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 7:26 [PATCH BlueZ v4 00/15] Properties + ObjectManager Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 01/15] gdbus: Move typedefs up Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 02/15] gdbus: Use macros to add annotations Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 03/15] gdbus: Add skeleton of DBus.Properties interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 04/15] gdbus: Implement DBus.Properties.Get method Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 05/15] gdbus: Implement DBus.Properties.GetAll method Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 06/15] gdbus: Implement DBus.Properties.Set method Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 07/15] gdbus: Add properties into Introspectable interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 08/15] gdbus: Add support for org.freedesktop.DBus.ObjectManager interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 09/15] gdbus: Group interface changes to reduce the amount of signals emitted Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 10/15] gdbus: Only export ObjectManager interface on root path Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 11/15] gdbus: Integrates ObjectManager with Properties interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 12/15] gdbus: Simplify code for appending properties Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 13/15] gdbus: Implement PropertiesChanged signal Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 14/15] Use DBus.Properties on Control interface Lucas De Marchi
2012-10-04 11:42 ` Anderson Lizardo
2012-10-04 14:22 ` Johan Hedberg
2012-10-04 7:26 ` [PATCH BlueZ v4 15/15] Use DBus.Properties on Manager interface Lucas De Marchi
2012-10-04 14:17 ` Johan Hedberg [this message]
2012-10-04 14:29 ` [PATCH BlueZ v4 00/15] Properties + ObjectManager Lucas De Marchi
2012-10-04 18:11 ` Marcel Holtmann
2012-10-04 18:27 ` Lucas De Marchi
2012-10-04 19:15 ` Marcel Holtmann
2012-10-04 19:23 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004141722.GA4173@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).