From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>,
linux-bluetooth@vger.kernel.org,
Lucas De Marchi <lucas.de.marchi@gmail.com>
Subject: Re: [PATCH BlueZ v4 14/15] Use DBus.Properties on Control interface
Date: Thu, 4 Oct 2012 17:22:10 +0300 [thread overview]
Message-ID: <20121004142210.GA9024@x220> (raw)
In-Reply-To: <CAJdJm_PZbDinMxO4En=3XMzjnNVTWpGQ9-pOV7VyfLJOJjY9Qg@mail.gmail.com>
Hi Lizardo,
On Thu, Oct 04, 2012, Anderson Lizardo wrote:
> On Thu, Oct 4, 2012 at 3:26 AM, Lucas De Marchi
> <lucas.demarchi@profusion.mobi> wrote:
> > @@ -77,13 +76,11 @@ static void state_changed(struct audio_device *dev, avctp_state_t old_state,
> > if (old_state != AVCTP_STATE_CONNECTED)
> > break;
> >
> > - value = FALSE;
> > g_dbus_emit_signal(conn, dev->path,
> > AUDIO_CONTROL_INTERFACE,
> > "Disconnected", DBUS_TYPE_INVALID);
> > - emit_property_changed(dev->path,
> > - AUDIO_CONTROL_INTERFACE, "Connected",
> > - DBUS_TYPE_BOOLEAN, &value);
> > + g_dbus_emit_property_changed(conn, dev->path,
> > + AUDIO_CONTROL_INTERFACE, "Connected");
>
> Out of curiosity, do you know why this API has Connected/Disconnected
> signals besides the PropertyChanged("Connected", ...) ?
I think those should have been marked as deprecated in 4.x and removed
for BlueZ 5.
Johan
next prev parent reply other threads:[~2012-10-04 14:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 7:26 [PATCH BlueZ v4 00/15] Properties + ObjectManager Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 01/15] gdbus: Move typedefs up Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 02/15] gdbus: Use macros to add annotations Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 03/15] gdbus: Add skeleton of DBus.Properties interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 04/15] gdbus: Implement DBus.Properties.Get method Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 05/15] gdbus: Implement DBus.Properties.GetAll method Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 06/15] gdbus: Implement DBus.Properties.Set method Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 07/15] gdbus: Add properties into Introspectable interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 08/15] gdbus: Add support for org.freedesktop.DBus.ObjectManager interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 09/15] gdbus: Group interface changes to reduce the amount of signals emitted Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 10/15] gdbus: Only export ObjectManager interface on root path Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 11/15] gdbus: Integrates ObjectManager with Properties interface Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 12/15] gdbus: Simplify code for appending properties Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 13/15] gdbus: Implement PropertiesChanged signal Lucas De Marchi
2012-10-04 7:26 ` [PATCH BlueZ v4 14/15] Use DBus.Properties on Control interface Lucas De Marchi
2012-10-04 11:42 ` Anderson Lizardo
2012-10-04 14:22 ` Johan Hedberg [this message]
2012-10-04 7:26 ` [PATCH BlueZ v4 15/15] Use DBus.Properties on Manager interface Lucas De Marchi
2012-10-04 14:17 ` [PATCH BlueZ v4 00/15] Properties + ObjectManager Johan Hedberg
2012-10-04 14:29 ` Lucas De Marchi
2012-10-04 18:11 ` Marcel Holtmann
2012-10-04 18:27 ` Lucas De Marchi
2012-10-04 19:15 ` Marcel Holtmann
2012-10-04 19:23 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004142210.GA9024@x220 \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox