From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/7] adapter: Convert adapter_get_address into simple getter
Date: Fri, 5 Oct 2012 11:39:01 +0300 [thread overview]
Message-ID: <20121005083901.GA25602@x220> (raw)
In-Reply-To: <1349425021-16766-1-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
On Fri, Oct 05, 2012, Szymon Janc wrote:
> Most uses of adapter_get_address were in form of:
>
> bdaddr_t addr;
> adapter_get_address(adapter, &addr);
> foo(&addr);
>
> Changing it to getter makes code simpler and avoid number of not
> needed memcpy.
>
> ---
> attrib/client.c | 2 +-
> audio/manager.c | 48 +++++---------
> plugins/adaptername.c | 4 +-
> plugins/dbusoob.c | 8 +--
> plugins/neard.c | 16 ++---
> plugins/service.c | 57 ++++++-----------
> plugins/wiimote.c | 5 +-
> profiles/alert/server.c | 4 +-
> profiles/gatt/gas.c | 16 ++---
> profiles/health/hdp.c | 14 ++---
> profiles/health/hdp_util.c | 24 ++++---
> profiles/input/device.c | 2 +-
> profiles/input/manager.c | 11 +---
> profiles/network/manager.c | 10 +--
> profiles/network/server.c | 8 +--
> profiles/proximity/monitor.c | 13 ++--
> profiles/sap/manager.c | 5 +-
> src/adapter.c | 13 ++--
> src/adapter.h | 2 +-
> src/attrib-server.c | 18 +++---
> src/device.c | 143 +++++++++++++++++-------------------------
> src/manager.c | 5 +-
> src/profile.c | 28 ++++-----
> 23 files changed, 179 insertions(+), 277 deletions(-)
All patches have been applied. Thanks.
Johan
next prev parent reply other threads:[~2012-10-05 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 8:16 [PATCH 1/7] adapter: Convert adapter_get_address into simple getter Szymon Janc
2012-10-05 8:16 ` [PATCH 2/7] storage: Constify bdaddr_t pointers parameters Szymon Janc
2012-10-05 8:16 ` [PATCH 3/7] adapter: Constify pointer returned by adapter_get_address Szymon Janc
2012-10-05 8:16 ` [PATCH 4/7] device: Convert device_get_address into simple getter Szymon Janc
2012-10-05 8:16 ` [PATCH 5/7] mgmt: Constify use of bdaddr_t pointer parameters Szymon Janc
2012-10-05 8:17 ` [PATCH 6/7] adapter: " Szymon Janc
2012-10-05 8:17 ` [PATCH 7/7] device: Make device_get_address return const pointer Szymon Janc
2012-10-05 8:39 ` Johan Hedberg [this message]
2012-10-05 10:54 ` [PATCH 1/7] adapter: Convert adapter_get_address into simple getter Anderson Lizardo
2012-10-05 11:00 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005083901.GA25602@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox