From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 00/15] Thermometer watchers API change + fixes
Date: Tue, 9 Oct 2012 18:03:03 +0200 [thread overview]
Message-ID: <20121009160303.GA8064@x220.c.hospitality.swisscom.com> (raw)
In-Reply-To: <1349781598-22580-1-git-send-email-andrzej.kaczmarek@tieto.com>
Hi Andrzej,
On Tue, Oct 09, 2012, Andrzej Kaczmarek wrote:
> Changes since v2:
> - restored special values for exponent and mantissa in API document
> and added note about IEEE spec
> - fixed parameters parsing for incoming measurement (memset was placed
> in wrong place)
>
> Also this was tested with PTS 4.5.3 and works fine now after memset fix,
> except for TP/THF/CO/BI-07-I which seems to have issue in PTS (there should
> be reserved value for temperature type but PTS sends 0x02 which is
> perfectly valid value thus it won't be discarded on our side).
>
>
> Andrzej Kaczmarek (15):
> thermometer: Store thermometer devices per-adapter
> thermometer: Register ThermometerManager interface on adapter path
> thermometer: Move watcher logic to adapter interface
> thermometer: Include remote device information in MeasurementReceived
> thermometer: Update API document
> thermometer: Update test script
> thermometer: Reformat MeasurementReceived description
> thermometer: Change string properties to lower-case
> thermometer: Update driver naming style
> thermometer: Add constant definition for watcher interface name
> thermometer: Add common function to write characteristics CCC
> thermometer: Refactor processing of measurement characteristic value
> thermometer: Fix whitespace
> thermometer: Fix indentation
> thermometer: Fix missing braces
>
> doc/thermometer-api.txt | 136 +++++-----
> profiles/thermometer/manager.c | 24 +-
> profiles/thermometer/thermometer.c | 512 +++++++++++++++++++++----------------
> profiles/thermometer/thermometer.h | 2 +
> test/test-thermometer | 16 +-
> 5 files changed, 395 insertions(+), 295 deletions(-)
All patches in this set have been applied. Thanks.
Johan
prev parent reply other threads:[~2012-10-09 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 11:19 [PATCH v3 00/15] Thermometer watchers API change + fixes Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 01/15] thermometer: Store thermometer devices per-adapter Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 02/15] thermometer: Register ThermometerManager interface on adapter path Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 03/15] thermometer: Move watcher logic to adapter interface Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 04/15] thermometer: Include remote device information in MeasurementReceived Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 05/15] thermometer: Update API document Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 06/15] thermometer: Update test script Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 07/15] thermometer: Reformat MeasurementReceived description Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 08/15] thermometer: Change string properties to lower-case Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 09/15] thermometer: Update driver naming style Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 10/15] thermometer: Add constant definition for watcher interface name Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 11/15] thermometer: Add common function to write characteristics CCC Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 12/15] thermometer: Refactor processing of measurement characteristic value Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 13/15] thermometer: Fix whitespace Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 14/15] thermometer: Fix indentation Andrzej Kaczmarek
2012-10-09 11:19 ` [PATCH v3 15/15] thermometer: Fix missing braces Andrzej Kaczmarek
2012-10-09 14:15 ` [PATCH v3 00/15] Thermometer watchers API change + fixes Anderson Lizardo
2012-10-09 16:03 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009160303.GA8064@x220.c.hospitality.swisscom.com \
--to=johan.hedberg@gmail.com \
--cc=andrzej.kaczmarek@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox