Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH -v2 1/8] Bluetooth: Fix L2CAP coding style
Date: Fri, 12 Oct 2012 14:16:28 +0300	[thread overview]
Message-ID: <20121012111626.GC28051@aemeltch-MOBL1> (raw)
In-Reply-To: <1349938311-25101-1-git-send-email-gustavo@padovan.org>

Hi Gustavo,

On Thu, Oct 11, 2012 at 02:51:44PM +0800, Gustavo Padovan wrote:
> -static inline int l2cap_get_conf_opt(void **ptr, int *type, int *olen, unsigned long *val)
> +static inline int l2cap_get_conf_opt(void **ptr, int *type, int *olen,
> +				     unsigned long *val)

For those functions you could also remove inline

Best regards 
Andrei Emeltchenko 



      parent reply	other threads:[~2012-10-12 11:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11  6:51 [PATCH -v2 1/8] Bluetooth: Fix L2CAP coding style Gustavo Padovan
2012-10-11  6:51 ` [PATCH -v2 2/8] Bluetooth: Move bt_accept_enqueue() to l2cap_sock.c Gustavo Padovan
2012-10-11 13:44   ` Marcel Holtmann
2012-10-12 11:13     ` Gustavo Padovan
2012-10-11  6:51 ` [PATCH -v2 3/8] Bluetooth: Remove parent socket usage from l2cap_core.c Gustavo Padovan
2012-10-11 13:45   ` Marcel Holtmann
2012-10-11  6:51 ` [PATCH -v2 4/8] Bluetooth: Add chan->ops->defer() Gustavo Padovan
2012-10-11 13:49   ` Marcel Holtmann
2012-10-12 10:48     ` Gustavo Padovan
2012-10-11  6:51 ` [PATCH -v2 5/8] Bluetooth: Remove GFP_ATOMIC usage from l2cap_core.c Gustavo Padovan
2012-10-11 13:50   ` Marcel Holtmann
2012-10-12 10:20     ` Gustavo Padovan
2012-10-11  6:51 ` [PATCH -v2 6/8] Bluetooth: use l2cap_chan_set_err() Gustavo Padovan
2012-10-11 13:51   ` Marcel Holtmann
2012-10-11  6:51 ` [PATCH -v2 7/8] Bluetooth: Use locked l2cap_state_change() Gustavo Padovan
2012-10-11 13:52   ` Marcel Holtmann
2012-10-11  6:51 ` [PATCH -v2 8/8] Bluetooth: Call ops->teardown() without checking for NULL Gustavo Padovan
2012-10-11 13:52   ` Marcel Holtmann
2012-10-11 13:43 ` [PATCH -v2 1/8] Bluetooth: Fix L2CAP coding style Marcel Holtmann
2012-10-12 11:16 ` Andrei Emeltchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121012111626.GC28051@aemeltch-MOBL1 \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox