[PATCH BlueZ] media: Fix leaking endpoint in case of failure to register SEP

[PATCH BlueZ] media: Fix leaking endpoint in case of failure to register SEP

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This can happen in case of AudioSink and/or AudioSource are disabled in
audio.conf.
---
 audio/media.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/audio/media.c b/audio/media.c
index 5c26035..f2b5b2f 100644
--- a/audio/media.c
+++ b/audio/media.c
@@ -769,7 +769,7 @@ static struct media_endpoint *media_endpoint_create(struct media_adapter *adapte
 	}
 
 	if (!succeeded) {
-		g_free(endpoint);
+		media_endpoint_destroy(endpoint);
 		return NULL;
 	}
 
-- 
1.7.11.4

Re: [PATCH BlueZ] media: Fix leaking endpoint in case of failure to register SEP

[Johan Hedberg]

Hi Luiz,

On Mon, Oct 15, 2012, Luiz Augusto von Dentz wrote:
> This can happen in case of AudioSink and/or AudioSource are disabled in
> audio.conf.
> ---
>  audio/media.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

This finally fixed the leak I've been seeing for a long time. Btw, this
happens also with no audio.conf at all as the default is to disable
AudioSource, so it's a bit misleading to imply (as you do in your commit
message) that this would happen only because of something in audio.conf.

Johan