Re: [PATCHv2 5/6] Bluetooth: AMP: Get amp_mgr reference in HS hci_conn

[Gustavo Padovan <gustavo@padovan.org>]

Hi Andrei,

* Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-10-15 16:21:21 +0300]:

> Hi Gustavo,
> 
> On Mon, Oct 15, 2012 at 09:49:03AM -0300, Gustavo Padovan wrote:
> > Hi Andrei,
> > 
> > * Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-10-15 11:58:43 +0300]:
> > 
> > > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > > 
> > > When assigning amp_mgr in hci_conn (type AMP_LINK) get also reference.
> > > In hci_conn_del those references would be put for both types.
> > > 
> > > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > > Acked-by: Marcel Holtmann <marcel@holtmann.org>
> > > ---
> > >  net/bluetooth/amp.c |    4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/net/bluetooth/amp.c b/net/bluetooth/amp.c
> > > index 59da0f1..e525e23 100644
> > > --- a/net/bluetooth/amp.c
> > > +++ b/net/bluetooth/amp.c
> > > @@ -123,9 +123,11 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
> > >  	hcon->attempt++;
> > >  	hcon->handle = __next_handle(mgr);
> > >  	hcon->remote_id = remote_id;
> > > -	hcon->amp_mgr = mgr;
> > >  	hcon->out = out;
> > >  
> > > +	hcon->amp_mgr = mgr;
> > > +	amp_mgr_get(mgr);
> > 
> > You did not take the comments from Marcel in this patch, please make the
> > change to amp_mgr_get() before sending this patch.
> 
> I was thinking of making separate patch since this might be used in
> several places so I would change it once instead of splitting this change
> to several patches.

Sure, but just send that patch before this one.

	Gustavo