From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5 v2] Bluetooth: Add initial support for LE-only controllers
Date: Mon, 22 Oct 2012 13:13:34 +0300 [thread overview]
Message-ID: <20121022101334.GA25370@x220> (raw)
In-Reply-To: <20121022100845.GA14263@aemeltch-MOBL1>
Hi Andrei,
On Mon, Oct 22, 2012, Andrei Emeltchenko wrote:
> > --- a/net/bluetooth/hci_core.c
> > +++ b/net/bluetooth/hci_core.c
> > @@ -178,48 +178,13 @@ static void hci_reset_req(struct hci_dev *hdev, unsigned long opt)
> >
> > static void bredr_init(struct hci_dev *hdev)
> > {
> > - struct hci_cp_delete_stored_link_key cp;
> > - __le16 param;
> > - __u8 flt_type;
> > -
>
> ...
>
> > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> > index 0383635..f4f0b8b 100644
> > --- a/net/bluetooth/hci_event.c
> > +++ b/net/bluetooth/hci_event.c
>
> ...
>
> > +static void bredr_init(struct hci_dev *hdev)
> > +{
>
> Is this a good idea to have two functions with the same names? Even static
> ones.
Another option would have been to call this bredr_setup since it's the
hci_setup function that calls it. Anyway, I'll wait for feedback from
Gustavo to see if he cares.
Johan
next prev parent reply other threads:[~2012-10-22 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 17:57 [PATCH 0/5 v2] Bluetooth: Add basic support for single-mode controllers Johan Hedberg
2012-10-19 17:57 ` Marcel Holtmann
2012-10-19 17:57 ` [PATCH 1/5 v2] Bluetooth: Add initial support for LE-only controllers Johan Hedberg
2012-10-22 10:08 ` Andrei Emeltchenko
2012-10-22 10:13 ` Johan Hedberg [this message]
2012-10-19 17:57 ` [PATCH 2/5 v2] Bluetooth: Fix LE MTU reporting for HCIGETDEVINFO Johan Hedberg
2012-10-19 17:57 ` [PATCH 3/5 v2] Bluetooth: Add setting of the LE event mask Johan Hedberg
2012-10-19 17:57 ` [PATCH 4/5 v2] Bluetooth: Fix HCI command sending when powering on LE-only adapters Johan Hedberg
2012-10-19 17:57 ` [PATCH 5/5 v2] Bluetooth: Read adversiting channel TX power during init sequence Johan Hedberg
2012-10-24 13:26 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022101334.GA25370@x220 \
--to=johan.hedberg@gmail.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).