linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Jeff Cook <jeff@deserettechnology.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17b5]
Date: Wed, 24 Oct 2012 10:11:49 -0200	[thread overview]
Message-ID: <20121024121149.GE13884@joana> (raw)
In-Reply-To: <5087B517.9090703@deserettechnology.com>

Hi Jeff,

* Jeff Cook <jeff@deserettechnology.com> [2012-10-24 03:29:59 -0600]:

> Hello all,
> 
> Please see included patch. First-time submitter so let me know if I did 
> something wrong.

Your patch is good, but you need to improve the way you submit it. We recommend
using 'git send-email' like this:

$ git send-email HEAD~1..HEAD

For sending the patch on the top of tree. You can also do combined use of 'git
format-patch' and 'git send-email' in case you want to add some message or to your
patch like the first-time submitter message you did here and these messages
needs to be added...

> 
> Thanks,
> Jeff
> --------------------
> 
> Vendor-specific ID for BCM20702A0.
> Support for bluetooth over Asus Wi-Fi GO!, included with Asus P8Z77-V
> Deluxe.
> 
> T:  Bus=07 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
> D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=0b05 ProdID=17b5 Rev=01.12
> S:  Manufacturer=Broadcom Corp
> S:  Product=BCM20702A0
> S:  SerialNumber=94DBC98AC113
> C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
> ---

... after these 3 dashes lines so they don't go the final commit when I apply
your patch.

	Gustavo

  reply	other threads:[~2012-10-24 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24  9:29 [PATCH] Bluetooth: Add support for BCM20702A0 [0b05, 17b5] Jeff Cook
2012-10-24 12:11 ` Gustavo Padovan [this message]
2012-10-24 12:20 ` Anderson Lizardo
2012-10-25 19:17   ` Jeff Cook
2012-10-26 12:49     ` Anderson Lizardo
2012-10-27 11:01 ` Jeff Cook
2012-10-31 18:15   ` Gustavo Padovan
2012-11-09 23:39 ` [PATCHv2] " Jeff Cook
2012-11-19 21:41   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121024121149.GE13884@joana \
    --to=gustavo@padovan.org \
    --cc=jeff@deserettechnology.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).