From: Gustavo Padovan <gustavo@padovan.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Mat Martineau <mathewm@codeaurora.org>,
linux-bluetooth@vger.kernel.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [bluetooth:master 12/33] net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
Date: Wed, 24 Oct 2012 20:01:31 -0200 [thread overview]
Message-ID: <20121024220131.GB3030@joana> (raw)
In-Reply-To: <508863c1.QTbySMnQ9kj6jDZz%fengguang.wu@intel.com>
Hi Fengguang,
* Fengguang Wu <fengguang.wu@intel.com> [2012-10-25 05:55:13 +0800]:
> Hi Mat,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
> head: 77220c6582477e696e3f3a53634fb1bd73128e95
> commit: 8eb200bd2f1c772dcb7f108f690ef03b054be04e [12/33] Bluetooth: Handle physical link completion
>
> + net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
>
> Please consider folding the attached diff :-)
Thanks a lot for finding this, but please can you send me a proper git
formatted patch with Signed-off-by message so I can add your patch to
bluetooth-next.
Gustavo
next prev parent reply other threads:[~2012-10-24 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 21:55 [bluetooth:master 12/33] net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static? Fengguang Wu
2012-10-24 22:01 ` Gustavo Padovan [this message]
2012-10-25 0:26 ` [PATCH] Bluetooth: l2cap_physical_cfm() can be static Fengguang Wu
2012-10-25 1:55 ` Marcel Holtmann
2012-10-25 7:13 ` Andrei Emeltchenko
2012-10-25 15:29 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024220131.GB3030@joana \
--to=gustavo@padovan.org \
--cc=fengguang.wu@intel.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).