* [bluetooth:master 12/33] net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
@ 2012-10-24 21:55 Fengguang Wu
2012-10-24 22:01 ` Gustavo Padovan
0 siblings, 1 reply; 6+ messages in thread
From: Fengguang Wu @ 2012-10-24 21:55 UTC (permalink / raw)
To: Mat Martineau; +Cc: linux-bluetooth, Gustavo Padovan
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
Hi Mat,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
head: 77220c6582477e696e3f3a53634fb1bd73128e95
commit: 8eb200bd2f1c772dcb7f108f690ef03b054be04e [12/33] Bluetooth: Handle physical link completion
+ net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
Please consider folding the attached diff :-)
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
[-- Attachment #2: make-it-static-8eb200b.diff --]
[-- Type: text/x-diff, Size: 543 bytes --]
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 898529d..24285e5 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -4492,7 +4492,7 @@ static void l2cap_do_move_cancel(struct l2cap_chan *chan, int result)
l2cap_ertm_send(chan);
}
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
u8 remote_amp_id)
{
BT_DBG("chan %p, result %d, local_amp_id %d, remote_amp_id %d",
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [bluetooth:master 12/33] net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
2012-10-24 21:55 [bluetooth:master 12/33] net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static? Fengguang Wu
@ 2012-10-24 22:01 ` Gustavo Padovan
2012-10-25 0:26 ` [PATCH] Bluetooth: l2cap_physical_cfm() can be static Fengguang Wu
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Padovan @ 2012-10-24 22:01 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Mat Martineau, linux-bluetooth, Gustavo Padovan
Hi Fengguang,
* Fengguang Wu <fengguang.wu@intel.com> [2012-10-25 05:55:13 +0800]:
> Hi Mat,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
> head: 77220c6582477e696e3f3a53634fb1bd73128e95
> commit: 8eb200bd2f1c772dcb7f108f690ef03b054be04e [12/33] Bluetooth: Handle physical link completion
>
> + net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static?
>
> Please consider folding the attached diff :-)
Thanks a lot for finding this, but please can you send me a proper git
formatted patch with Signed-off-by message so I can add your patch to
bluetooth-next.
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Bluetooth: l2cap_physical_cfm() can be static
2012-10-24 22:01 ` Gustavo Padovan
@ 2012-10-25 0:26 ` Fengguang Wu
2012-10-25 1:55 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: Fengguang Wu @ 2012-10-25 0:26 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: Mat Martineau, linux-bluetooth
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
net/bluetooth/l2cap_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next.orig/net/bluetooth/l2cap_core.c 2012-10-25 08:23:52.456742699 +0800
+++ linux-next/net/bluetooth/l2cap_core.c 2012-10-25 08:23:55.056742760 +0800
@@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
l2cap_ertm_send(chan);
}
-void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
+static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
u8 remote_amp_id)
{
BT_DBG("chan %p, result %d, local_amp_id %d, remote_amp_id %d",
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static
2012-10-25 0:26 ` [PATCH] Bluetooth: l2cap_physical_cfm() can be static Fengguang Wu
@ 2012-10-25 1:55 ` Marcel Holtmann
2012-10-25 7:13 ` Andrei Emeltchenko
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2012-10-25 1:55 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Gustavo Padovan, Mat Martineau, linux-bluetooth
Hi Fengguang,
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> net/bluetooth/l2cap_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next.orig/net/bluetooth/l2cap_core.c 2012-10-25 08:23:52.456742699 +0800
> +++ linux-next/net/bluetooth/l2cap_core.c 2012-10-25 08:23:55.056742760 +0800
> @@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
> l2cap_ertm_send(chan);
> }
>
> -void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
> +static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
> u8 remote_amp_id)
I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight
or we need that later on to be actually public.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static
2012-10-25 1:55 ` Marcel Holtmann
@ 2012-10-25 7:13 ` Andrei Emeltchenko
2012-10-25 15:29 ` Mat Martineau
0 siblings, 1 reply; 6+ messages in thread
From: Andrei Emeltchenko @ 2012-10-25 7:13 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Fengguang Wu, Gustavo Padovan, Mat Martineau, linux-bluetooth
Hi,
On Wed, Oct 24, 2012 at 06:55:34PM -0700, Marcel Holtmann wrote:
> Hi Fengguang,
>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > net/bluetooth/l2cap_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-next.orig/net/bluetooth/l2cap_core.c 2012-10-25 08:23:52.456742699 +0800
> > +++ linux-next/net/bluetooth/l2cap_core.c 2012-10-25 08:23:55.056742760 +0800
> > @@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
> > l2cap_ertm_send(chan);
> > }
> >
> > -void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
> > +static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
> > u8 remote_amp_id)
>
> I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight
> or we need that later on to be actually public.
Agree with Marcel here. This shall be public.
Best regards
Andrei Emeltchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static
2012-10-25 7:13 ` Andrei Emeltchenko
@ 2012-10-25 15:29 ` Mat Martineau
0 siblings, 0 replies; 6+ messages in thread
From: Mat Martineau @ 2012-10-25 15:29 UTC (permalink / raw)
To: Andrei Emeltchenko
Cc: Marcel Holtmann, Fengguang Wu, Gustavo Padovan, linux-bluetooth
Hi -
On Thu, 25 Oct 2012, Andrei Emeltchenko wrote:
> Hi,
>
> On Wed, Oct 24, 2012 at 06:55:34PM -0700, Marcel Holtmann wrote:
>> Hi Fengguang,
>>
>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>>> ---
>>> net/bluetooth/l2cap_core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-next.orig/net/bluetooth/l2cap_core.c 2012-10-25 08:23:52.456742699 +0800
>>> +++ linux-next/net/bluetooth/l2cap_core.c 2012-10-25 08:23:55.056742760 +0800
>>> @@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct
>>> l2cap_ertm_send(chan);
>>> }
>>>
>>> -void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
>>> +static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id,
>>> u8 remote_amp_id)
>>
>> I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight
>> or we need that later on to be actually public.
>
> Agree with Marcel here. This shall be public.
Yes, it does need to be public. Andrei will need to call it from the
AMP physical link code, but I'm not sure exactly where (HCI event
handling or somewhere in amp.c or a2mp.c).
--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-25 15:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 21:55 [bluetooth:master 12/33] net/bluetooth/l2cap_core.c:4495:6: sparse: symbol 'l2cap_physical_cfm' was not declared. Should it be static? Fengguang Wu
2012-10-24 22:01 ` Gustavo Padovan
2012-10-25 0:26 ` [PATCH] Bluetooth: l2cap_physical_cfm() can be static Fengguang Wu
2012-10-25 1:55 ` Marcel Holtmann
2012-10-25 7:13 ` Andrei Emeltchenko
2012-10-25 15:29 ` Mat Martineau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).