From: Gustavo Padovan <gustavo@padovan.org>
To: Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
linux-bluetooth@vger.kernel.org
Subject: Re: [bluetooth:master 60/61] net/bluetooth/hci_core.c:683:19: sparse: incorrect type in assignment (different base types)
Date: Sat, 10 Nov 2012 19:23:01 +0100 [thread overview]
Message-ID: <20121110182301.GA11192@joana> (raw)
In-Reply-To: <20121109151649.GA27541@x220.P-661HNU-F1>
Hi,
* Johan Hedberg <johan.hedberg@intel.com> [2012-11-09 17:16:49 +0200]:
> Hi,
>
> On Fri, Nov 09, 2012, kbuild test robot wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
> > head: 108777e09bbe7874dc5224173a1e3f3ee4ac6471
> > commit: c82263e2cfbf6d5c030d0e424ecc91402910e46e [60/61] Bluetooth: Add support for setting LE advertising data
> >
> >
> > sparse warnings:
> >
> > + net/bluetooth/hci_core.c:683:19: sparse: incorrect type in assignment (different base types)
> > net/bluetooth/hci_core.c:683:19: expected unsigned char [unsigned] [addressable] [usertype] length
> > net/bluetooth/hci_core.c:683:19: got restricted __le16 [usertype] <noident>
> >
> > vim +683 net/bluetooth/hci_core.c
> >
> > c82263e2 Johan Hedberg 2012-11-08 667 goto unlock;
> > c82263e2 Johan Hedberg 2012-11-08 668 }
> > c82263e2 Johan Hedberg 2012-11-08 669
> > c82263e2 Johan Hedberg 2012-11-08 670 memset(&cp, 0, sizeof(cp));
> > c82263e2 Johan Hedberg 2012-11-08 671
> > c82263e2 Johan Hedberg 2012-11-08 672 len = create_ad(hdev, cp.data);
> > c82263e2 Johan Hedberg 2012-11-08 673
> > c82263e2 Johan Hedberg 2012-11-08 674 if (hdev->adv_data_len == len &&
> > c82263e2 Johan Hedberg 2012-11-08 675 memcmp(cp.data, hdev->adv_data, len) == 0) {
> > c82263e2 Johan Hedberg 2012-11-08 676 err = 0;
> > c82263e2 Johan Hedberg 2012-11-08 677 goto unlock;
> > c82263e2 Johan Hedberg 2012-11-08 678 }
> > c82263e2 Johan Hedberg 2012-11-08 679
> > c82263e2 Johan Hedberg 2012-11-08 680 memcpy(hdev->adv_data, cp.data, sizeof(cp.data));
> > c82263e2 Johan Hedberg 2012-11-08 681 hdev->adv_data_len = len;
> > c82263e2 Johan Hedberg 2012-11-08 682
> > c82263e2 Johan Hedberg 2012-11-08 @683 cp.length = cpu_to_le16(len);
>
> This is actually a real bug which would show up at least on big endian
> systems: cp.length is just one byte so no byte order conversion should
> be attempted. Gustavo, do you want me to send a patch to fix it or will
> you remove this patch from the current tree and let me send a revised
> version?
I fixed this patch and pushed a new version to bluetooth-next. Should be all
good now.
Gustavo
prev parent reply other threads:[~2012-11-10 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 11:28 [bluetooth:master 60/61] net/bluetooth/hci_core.c:683:19: sparse: incorrect type in assignment (different base types) kbuild test robot
2012-11-09 15:16 ` Johan Hedberg
2012-11-10 18:23 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121110182301.GA11192@joana \
--to=gustavo@padovan.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).