Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Mikel Astiz <mikel.astiz.oss@gmail.com>,
	linux-bluetooth@vger.kernel.org,
	Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: Re: [RFC v0 0/7] Manager/Adapter transition to ObjectManager
Date: Mon, 12 Nov 2012 21:26:07 +0200	[thread overview]
Message-ID: <20121112192607.GA6300@x220.P-661HNU-F1> (raw)
In-Reply-To: <20121112172346.GA6267@x220.P-661HNU-F1>

Hi Mikel,

> > Mikel Astiz (7):
> >   manager: Expose default adapter using property
> >   manager: Remove redundant D-Bus signals
> >   manager: Remove redundant Adapters property
> >   adapter: Remove redundant D-Bus signals
> >   adapter: Remove DevicesFound signal
> >   adapter: Remove redundant Devices property
> >   adapter: Remove FindDevice method from D-Bus API
> > 
> >  doc/adapter-api.txt |  32 +--------
> >  doc/manager-api.txt |  28 +-------
> >  src/adapter.c       | 187 +---------------------------------------------------
> >  src/manager.c       | 103 +++++++----------------------
> >  4 files changed, 29 insertions(+), 321 deletions(-)
> 
> All patches except 5/7 (which needs a bit more discussion) have been
> applied. Thanks.

I had to revert all of these since I didn't realize you hadn't updated
the test scripts (all of which broke with these patches). Also, it seems
the DefaultAdapter patch is also broken since I never saw that property
(e.g. with test/get-managed-objects). Please send a new patch set once
you've got the scripts converted and the DefaultAdapter patch fixed.
Thanks.

Johan

  reply	other threads:[~2012-11-12 19:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 14:30 [RFC v0 0/7] Manager/Adapter transition to ObjectManager Mikel Astiz
2012-11-08 14:30 ` [RFC v0 1/7] manager: Expose default adapter using property Mikel Astiz
2012-11-08 14:30 ` [RFC v0 2/7] manager: Remove redundant D-Bus signals Mikel Astiz
2012-11-08 14:30 ` [RFC v0 3/7] manager: Remove redundant Adapters property Mikel Astiz
2012-11-08 14:30 ` [RFC v0 4/7] adapter: Remove redundant D-Bus signals Mikel Astiz
2012-11-08 14:30 ` [RFC v0 5/7] adapter: Remove DevicesFound signal Mikel Astiz
2012-11-11 13:19   ` Johan Hedberg
2012-11-12  8:45     ` Mikel Astiz
2012-11-08 14:30 ` [RFC v0 6/7] adapter: Remove redundant Devices property Mikel Astiz
2012-11-08 14:30 ` [RFC v0 7/7] adapter: Remove FindDevice method from D-Bus API Mikel Astiz
2012-11-12 17:23 ` [RFC v0 0/7] Manager/Adapter transition to ObjectManager Johan Hedberg
2012-11-12 19:26   ` Johan Hedberg [this message]
2012-11-13 10:44     ` Mikel Astiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112192607.GA6300@x220.P-661HNU-F1 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz.oss@gmail.com \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox