From: Gustavo Padovan <gustavo@padovan.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 4/4] Bluetooth: Set local_amp_id after getting Phylink Completed evt
Date: Mon, 19 Nov 2012 19:28:12 -0200 [thread overview]
Message-ID: <20121119212812.GB14006@joana> (raw)
In-Reply-To: <1352996096-27374-4-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
* Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> [2012-11-15 18:14:56 +0200]:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> local_amp_id is used in l2cap_physical_cfm and shall be set up
> before calling it.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/amp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/bluetooth/amp.c b/net/bluetooth/amp.c
> index eb61aaa..ac9e8fe 100644
> --- a/net/bluetooth/amp.c
> +++ b/net/bluetooth/amp.c
> @@ -392,6 +392,7 @@ void amp_physical_cfm(struct hci_conn *bredr_hcon, struct hci_conn *hs_hcon)
>
> set_bit(FLAG_EFS_ENABLE, &bredr_chan->flags);
> bredr_chan->remote_amp_id = hs_hcon->remote_id;
> + bredr_chan->local_amp_id = hs_hcon->hdev->id;
> bredr_chan->hs_hcon = hs_hcon;
> bredr_chan->conn->mtu = hs_hcon->hdev->block_mtu;
I was able to apply patches 1 and 3 to bluetooth-next. The other 2 doesn't
apply for some reason, please rebase. Thanks.
Gustavo
next prev parent reply other threads:[~2012-11-19 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 16:14 [RFC 1/4] Bluetooth: Use __l2cap_no_conn_pending helper Andrei Emeltchenko
2012-11-15 16:14 ` [RFC 2/4] Bluetooth: Fix sending L2CAP Create Chan Req Andrei Emeltchenko
2012-11-15 23:56 ` Marcel Holtmann
2012-11-15 16:14 ` [RFC 3/4] Bluetooth: Remove unneeded local_amp_id initialization Andrei Emeltchenko
2012-11-15 23:53 ` Marcel Holtmann
2012-11-15 16:14 ` [RFC 4/4] Bluetooth: Set local_amp_id after getting Phylink Completed evt Andrei Emeltchenko
2012-11-15 23:54 ` Marcel Holtmann
2012-11-19 21:28 ` Gustavo Padovan [this message]
2012-11-20 15:16 ` [RFC 0/4] Bluetooth: AMP fixes Andrei Emeltchenko
2012-11-20 15:16 ` [RFC 1/4] Bluetooth: Fix sending L2CAP Create Chan Req Andrei Emeltchenko
2012-11-20 15:16 ` [RFC 2/4] Bluetooth: Set local_amp_id after getting Phylink Completed evt Andrei Emeltchenko
2012-11-20 15:16 ` [RFC 3/4] Bluetooth: Improve error message printing Andrei Emeltchenko
2012-11-20 15:16 ` [RFC 4/4] Bluetooth: AMP: Set no FCS for incoming L2CAP chan Andrei Emeltchenko
2012-11-20 17:56 ` Gustavo Padovan
2012-11-15 23:53 ` [RFC 1/4] Bluetooth: Use __l2cap_no_conn_pending helper Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119212812.GB14006@joana \
--to=gustavo@padovan.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).