linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] audio: Auto connect AVRCP in case of A2DP source is connected
@ 2012-11-20  9:13 Luiz Augusto von Dentz
  2012-11-20  9:23 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2012-11-20  9:13 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This enables the same logic used for A2DP sink, so it attempt to
connect AVRCP if remote device support it.

Note this is necessary for some devices e.g. WP7 that don't connect
even when being the initiator because it is not mandatory for target
to do so even though it is recommended to avoid collisions while trying
to estabilish the connection.
---
 profiles/audio/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/device.c b/profiles/audio/device.c
index df57d81..5176a60 100644
--- a/profiles/audio/device.c
+++ b/profiles/audio/device.c
@@ -269,7 +269,7 @@ static void device_avdtp_cb(struct audio_device *dev, struct avdtp *session,
 				avdtp_session_state_t new_state,
 				void *user_data)
 {
-	if (!dev->sink || !dev->control)
+	if (!dev->control)
 		return;
 
 	if (new_state == AVDTP_SESSION_STATE_CONNECTED) {
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ] audio: Auto connect AVRCP in case of A2DP source is connected
  2012-11-20  9:13 [PATCH BlueZ] audio: Auto connect AVRCP in case of A2DP source is connected Luiz Augusto von Dentz
@ 2012-11-20  9:23 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-11-20  9:23 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth

Hi Luiz,

On Tue, Nov 20, 2012, Luiz Augusto von Dentz wrote:
> This enables the same logic used for A2DP sink, so it attempt to
> connect AVRCP if remote device support it.
> 
> Note this is necessary for some devices e.g. WP7 that don't connect
> even when being the initiator because it is not mandatory for target
> to do so even though it is recommended to avoid collisions while trying
> to estabilish the connection.
> ---
>  profiles/audio/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-20  9:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20  9:13 [PATCH BlueZ] audio: Auto connect AVRCP in case of A2DP source is connected Luiz Augusto von Dentz
2012-11-20  9:23 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).