Linux bluetooth development
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Syam Sidhardhan <s.syam@samsung.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 2/2 v1] l2test: Add support to test auto select PSM
Date: Tue, 20 Nov 2012 15:52:13 -0200	[thread overview]
Message-ID: <20121120175213.GH14006@joana> (raw)
In-Reply-To: <1353428151-11925-1-git-send-email-s.syam@samsung.com>

Hi Syam,

* Syam Sidhardhan <s.syam@samsung.com> [2012-11-20 21:45:51 +0530]:

> This patch enable us to test the auto select PSM for server by passing
> PSM value as 0.
> 
> Ex: l2test -d -P 0
> l2test[2585]: Waiting for connection on psm 4097 ...
> ---
> v1-> Corrected the misplaced code
> 
>  test/l2test.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/test/l2test.c b/test/l2test.c
> index 7645681..485887f 100644
> --- a/test/l2test.c
> +++ b/test/l2test.c
> @@ -87,7 +87,7 @@ static long buffer_size = 2048;
>  
>  /* Default addr and psm and cid */
>  static bdaddr_t bdaddr;
> -static unsigned short psm = 0x1011;
> +static unsigned short psm = 0;

Your patch makes the client side to always pass the psm option and I don't
think this is a good approach. I think we need something smarter here to not
break things.

	Gustavo

  reply	other threads:[~2012-11-20 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 16:15 [PATCH BlueZ 2/2 v1] l2test: Add support to test auto select PSM Syam Sidhardhan
2012-11-20 17:52 ` Gustavo Padovan [this message]
2012-12-04 14:36   ` Syam Sidhardhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121120175213.GH14006@joana \
    --to=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=s.syam@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox