From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 4/5] adaptername: Remove not needed empty remove callback
Date: Mon, 26 Nov 2012 13:26:15 +0200 [thread overview]
Message-ID: <20121126112615.GA25303@x220> (raw)
In-Reply-To: <7243377.vN3q5Zuh5I@uw000953>
Hi Szymon,
On Mon, Nov 26, 2012, Szymon Janc wrote:
> On Monday 26 of November 2012 12:45:30 Anderson Lizardo wrote:
> > Hi Szymon,
>
> Hi Anderson,
>
> >
> > On Mon, Nov 26, 2012 at 5:07 AM, Szymon Janc <szymon.janc@tieto.com> wrote:
> > > static struct btd_adapter_driver adaptername_driver = {
> > > .name = "adaptername",
> > > .probe = adaptername_probe,
> > > - .remove = adaptername_remove,
> > > + .remove = NULL,
> > > };
> >
> > This variable is static, so not explicitly initialized members will be NULL.
>
> Yes, yet according to code style for bluez statics should be initialized
> explicitly, right? Or this does not count for struct members?
I've left this out for struct members at least in new code so I'd say
that it's not needed.
Johan
next prev parent reply other threads:[~2012-11-26 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 9:07 [PATCH 1/5] service: Fix not unreferencing adapter in case of error Szymon Janc
2012-11-26 9:07 ` [PATCH 2/5] service: Remove not needed initialization Szymon Janc
2012-11-26 9:07 ` [PATCH 3/5] adapter: Call driver remove callback when unregistering driver Szymon Janc
2012-11-26 9:07 ` [PATCH 4/5] adaptername: Remove not needed empty remove callback Szymon Janc
2012-11-26 10:45 ` Anderson Lizardo
2012-11-26 10:52 ` Szymon Janc
2012-11-26 11:26 ` Johan Hedberg [this message]
2012-11-26 12:57 ` Anderson Lizardo
2012-11-26 9:07 ` [PATCH 5/5] formfactor: " Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126112615.GA25303@x220 \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).