* [PATCH v2 1/2] adaptername: Remove not needed empty remove callback
@ 2012-11-26 11:48 Szymon Janc
2012-11-26 11:48 ` [PATCH v2 2/2] formfactor: " Szymon Janc
2012-11-26 12:56 ` [PATCH v2 1/2] adaptername: " Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Szymon Janc @ 2012-11-26 11:48 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
Remove callback is called only if it is not NULL so there is no need to
register empty callback function.
---
plugins/adaptername.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/plugins/adaptername.c b/plugins/adaptername.c
index 353f11c..2013b7b 100644
--- a/plugins/adaptername.c
+++ b/plugins/adaptername.c
@@ -261,14 +261,9 @@ fail:
return FALSE;
}
-static void adaptername_remove(struct btd_adapter *adapter)
-{
-}
-
static struct btd_adapter_driver adaptername_driver = {
.name = "adaptername",
.probe = adaptername_probe,
- .remove = adaptername_remove,
};
static int adaptername_init(void)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] formfactor: Remove not needed empty remove callback
2012-11-26 11:48 [PATCH v2 1/2] adaptername: Remove not needed empty remove callback Szymon Janc
@ 2012-11-26 11:48 ` Szymon Janc
2012-11-26 12:56 ` [PATCH v2 1/2] adaptername: " Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Szymon Janc @ 2012-11-26 11:48 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
Remove callback is called only if it is not NULL so there is no need to
register empty callback function.
---
plugins/formfactor.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/plugins/formfactor.c b/plugins/formfactor.c
index 0e19ac6..1978f03 100644
--- a/plugins/formfactor.c
+++ b/plugins/formfactor.c
@@ -124,14 +124,9 @@ static int formfactor_probe(struct btd_adapter *adapter)
return 0;
}
-static void formfactor_remove(struct btd_adapter *adapter)
-{
-}
-
static struct btd_adapter_driver formfactor_driver = {
.name = "formfactor",
.probe = formfactor_probe,
- .remove = formfactor_remove,
};
static int formfactor_init(void)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] adaptername: Remove not needed empty remove callback
2012-11-26 11:48 [PATCH v2 1/2] adaptername: Remove not needed empty remove callback Szymon Janc
2012-11-26 11:48 ` [PATCH v2 2/2] formfactor: " Szymon Janc
@ 2012-11-26 12:56 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2012-11-26 12:56 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
On Mon, Nov 26, 2012, Szymon Janc wrote:
> Remove callback is called only if it is not NULL so there is no need to
> register empty callback function.
> ---
> plugins/adaptername.c | 5 -----
> 1 file changed, 5 deletions(-)
Both patches have been applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-26 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-26 11:48 [PATCH v2 1/2] adaptername: Remove not needed empty remove callback Szymon Janc
2012-11-26 11:48 ` [PATCH v2 2/2] formfactor: " Szymon Janc
2012-11-26 12:56 ` [PATCH v2 1/2] adaptername: " Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).