linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Frédéric Danis" <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 7/7] event: Store link key infos in new keys file
Date: Tue, 27 Nov 2012 13:03:32 +0200	[thread overview]
Message-ID: <20121127110332.GA23883@x220> (raw)
In-Reply-To: <1354006193-7199-7-git-send-email-frederic.danis@linux.intel.com>

Hi Frederic,

On Tue, Nov 27, 2012, Frédéric Danis wrote:
> ---
>  src/event.c |   59 +++++++++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 47 insertions(+), 12 deletions(-)

After these patches there's the following leak:

==23252== 32,808 bytes in 1 blocks are definitely lost in loss record 210 of 210
==23252==    at 0x4A0883C: malloc (vg_replace_malloc.c:270)
==23252==    by 0x565E25F: __alloc_dir (opendir.c:199)
==23252==    by 0x175382: load_devices (adapter.c:2005)
==23252==    by 0x178E50: adapter_init (adapter.c:2896)
==23252==    by 0x17391E: btd_manager_register_adapter (manager.c:334)
==23252==    by 0x1883E1: mgmt_event.part.36 (mgmt.c:1081)
==23252==    by 0x4C78A74: g_main_context_dispatch (gmain.c:2715)
==23252==    by 0x4C78DA7: g_main_context_iterate.isra.24 (gmain.c:3290)
==23252==    by 0x4C791A1: g_main_loop_run (gmain.c:3484)
==23252==    by 0x121640: main (main.c:544)

That seems to be simple missing closedir() call. Didn't I already tell
you to always use valgrind?

Another problem with these is that I'm getting over a hundred unexpected
device objects which I didn't have before. It seems that this is because
you convert the classes file into the device storage instead of the
cache. It might be due to some other info as well though.

Johan

      reply	other threads:[~2012-11-27 11:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27  8:49 [PATCH 1/7] doc: Update settings-storage.txt Frédéric Danis
2012-11-27  8:49 ` [PATCH 2/7] adapter: Load devices from new storage architecture Frédéric Danis
2012-11-27  8:49 ` [PATCH 3/7] adapter: Add destination file to convert_file() Frédéric Danis
2012-11-27  8:49 ` [PATCH 4/7] adapter: Convert storage linkkeys file Frédéric Danis
2012-11-27  8:49 ` [PATCH 5/7] device: Remove keys file in device_remove_stored() Frédéric Danis
2012-11-27  8:49 ` [PATCH 6/7] adapter: Upload link keys from new storage Frédéric Danis
2012-11-27  8:49 ` [PATCH 7/7] event: Store link key infos in new keys file Frédéric Danis
2012-11-27 11:03   ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121127110332.GA23883@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=frederic.danis@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).