Re: [PATCH BlueZ] gdbus: Fix crash error when calling g_dbus_remove_all_watches

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Thomasz,

On Fri, Aug 24, 2012, Tomasz Bursztyka wrote:
> ---
> Hi,
> 
> While using gdbus on some other code, I found out that bug around g_dbus_remove_all_watches() usage.
> 
> Tomasz
> 
>  gdbus/watch.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/gdbus/watch.c b/gdbus/watch.c
> index d749176..968a38a 100644
> --- a/gdbus/watch.c
> +++ b/gdbus/watch.c
> @@ -298,6 +298,9 @@ static void filter_data_call_and_free(struct filter_data *data)
>  		g_free(cb);
>  	}
>  
> +	g_slist_free(data->callbacks);
> +	data->callbacks = NULL;
> +
>  	filter_data_free(data);
>  }

It seems this patch never got applied. Is it so that no-one else has
seen the issue. Could someone (through basic static analysis) confirm if
the patch is correct? It'd be nice if we could also have a back trace of
the crash in the commit message.

Johan