Re: [RFC 4/4] Bluetooth: Set link parameters for outgoing connections

[Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>]

Hi Frédéric,

On Wed, Nov 28, 2012 at 07:28:36PM +0100, Frédéric Dalleau wrote:
> In order to establish the connection, the outgoing connection must also
> request the codec. Here we need to set a bit in ACL connection flag to set up
> the correct parameters if the ACL connection is not up yet.

...

> @@ -585,7 +586,8 @@ void hci_chan_list_flush(struct hci_conn *conn);
>  struct hci_chan *hci_chan_lookup_handle(struct hci_dev *hdev, __u16 handle);
>  
>  struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst,
> -			     __u8 dst_type, __u8 sec_level, __u8 auth_type);
> +			     __u8 dst_type, __u8 sec_level,
> +			     __u8 auth_type, __u8 codec);

somehow I do not like this new parameter for hci_connect as it is only
needed for SCO.

Now I am not sure we need hci_connect super-function if it only calls
appropriate hci_connect_{sco,acl,le} based on type.

...
> @@ -552,7 +559,8 @@ static struct hci_conn *hci_connect_acl(struct hci_dev *hdev, bdaddr_t *dst,
>  }
>  
>  static struct hci_conn *hci_connect_sco(struct hci_dev *hdev, int type,
> -				bdaddr_t *dst, u8 sec_level, u8 auth_type)
> +					bdaddr_t *dst, u8 sec_level,
> +					u8 auth_type, u8 codec)

what about directly calling hci_connect_sco with the parameter?

...

Best regards 
Andrei Emeltchenko