From: Gustavo Padovan <gustavo@padovan.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [RFC 04/16] Bluetooth: add l2cap_state_change_and_error()
Date: Wed, 12 Dec 2012 17:26:24 -0200 [thread overview]
Message-ID: <20121212192624.GA5554@joana> (raw)
In-Reply-To: <CAJdJm_PMBC8nivsJuYDp-wW5ei1WF7m3SJzh78RScUyQu5ApJQ@mail.gmail.com>
* Anderson Lizardo <anderson.lizardo@openbossa.org> [2012-12-12 09:40:06 -0400]:
> Hi Gustavo,
>
> On Wed, Dec 12, 2012 at 12:13 AM, Gustavo Padovan <gustavo@padovan.org> wrote:
> > @@ -238,7 +244,7 @@ static inline void l2cap_chan_set_err(struct l2cap_chan *chan, int err)
> > struct sock *sk = chan->sk;
> >
> > lock_sock(sk);
> > - __l2cap_chan_set_err(chan, err);
> > + chan->ops->state_change(chan, chan->state, 0);
>
> Why "0" and not "err" ?
Yes, it is "err" here. I fixed both issues you reported.
Gustavo
next prev parent reply other threads:[~2012-12-12 19:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 4:13 [RFC 00/16] Completely remove socket dependency from l2cap_core.c Gustavo Padovan
2012-12-12 4:13 ` [RFC 01/16] Bluetooth: Add src and dst info to struct l2cap_chan Gustavo Padovan
2012-12-12 4:13 ` [RFC 02/16] Bluetooth: Remove sk_sndtimeo from l2cap_core.c Gustavo Padovan
2012-12-12 4:13 ` [RFC 03/16] Bluetooth: extend state_change() call to report errors too Gustavo Padovan
2012-12-12 13:25 ` Anderson Lizardo
2012-12-12 4:13 ` [RFC 04/16] Bluetooth: add l2cap_state_change_and_error() Gustavo Padovan
2012-12-12 13:40 ` Anderson Lizardo
2012-12-12 19:26 ` Gustavo Padovan [this message]
2012-12-12 4:13 ` [RFC 05/16] Bluetooth: Add missing braces to an "else if" Gustavo Padovan
2012-12-12 4:13 ` [RFC 06/16] Bluetooth: use l2cap_chan_ready() instead of duplicate code Gustavo Padovan
2012-12-12 4:13 ` [RFC 07/16] Bluetooth: duplicate DEFER_SETUP flag on l2cap_chan Gustavo Padovan
2012-12-12 4:13 ` [RFC 08/16] Bluetooth: Improving locking in l2cap_conn_start() Gustavo Padovan
2012-12-12 4:13 ` [RFC 09/16] Bluetooth: lock socket in defer_cb call Gustavo Padovan
2012-12-12 4:13 ` [RFC 10/16] Bluetooth: Remove socket lock from state_change() in l2cap_core Gustavo Padovan
2012-12-12 4:13 ` [RFC 11/16] Bluetooth: remove parent socket usage from l2cap_core.c Gustavo Padovan
2012-12-12 4:13 ` [RFC 12/16] Bluetooth: Use abstract chan->data in comparison Gustavo Padovan
2012-12-12 8:20 ` Andrei Emeltchenko
2012-12-12 19:57 ` Gustavo Padovan
2012-12-12 4:13 ` [RFC 13/16] Bluetooth: Move l2cap_wait_ack() to l2cap_sock.c Gustavo Padovan
2012-12-12 4:13 ` [RFC 14/16] Bluetooth: Create l2cap->ops->resume() Gustavo Padovan
2012-12-12 4:13 ` [RFC 15/16] Bluetooth: Create l2cap->ops->set_shutdown() Gustavo Padovan
2012-12-12 4:13 ` [RFC 16/16] Bluetooth: Remove sk member from struct l2cap_chan Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212192624.GA5554@joana \
--to=gustavo@padovan.org \
--cc=anderson.lizardo@openbossa.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).