* [RFC 0/3] Bluetooth: mgmt API for reading supported codecs
@ 2012-11-22 12:05 Michael Knudsen
2012-11-22 12:05 ` [RFC 1/3] Bluetooth: Add HCI feature bit definition for transparent SCO Michael Knudsen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael Knudsen @ 2012-11-22 12:05 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Michael Knudsen
This adds a mgmt API for reading out the list of codecs supported by a
given controller. PCM is hardwired as it is always supported. Other
codecs are added once the supported features bits are read out from
the chip. Later, on devices with support for it, the appropriate HCI
command is used to read out the list of codecs for which there are no
HCI feature bits defined (e.g. mSBC).
Michael Knudsen (3):
Bluetooth: Add HCI feature bit definition for transparent SCO
Bluetooth: Add HCI Coding Format definitions
Bluetooth: Provide mgmt API for reading list of supported codecs
include/net/bluetooth/hci.h | 10 ++++++++++
include/net/bluetooth/hci_core.h | 2 ++
include/net/bluetooth/mgmt.h | 7 +++++++
net/bluetooth/hci_core.c | 3 +++
net/bluetooth/hci_event.c | 21 +++++++++++++++++++++
net/bluetooth/mgmt.c | 36 ++++++++++++++++++++++++++++++++++++
6 files changed, 79 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC 1/3] Bluetooth: Add HCI feature bit definition for transparent SCO
2012-11-22 12:05 [RFC 0/3] Bluetooth: mgmt API for reading supported codecs Michael Knudsen
@ 2012-11-22 12:05 ` Michael Knudsen
2012-11-22 12:05 ` [RFC 2/3] Bluetooth: Add HCI Coding Format definitions Michael Knudsen
2012-11-22 12:05 ` [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs Michael Knudsen
2 siblings, 0 replies; 6+ messages in thread
From: Michael Knudsen @ 2012-11-22 12:05 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Michael Knudsen
---
include/net/bluetooth/hci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 45eee08..45ec1de 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -233,6 +233,7 @@ enum {
#define LMP_CVSD 0x01
#define LMP_PSCHEME 0x02
#define LMP_PCONTROL 0x04
+#define LMP_TRSP_SCO 0x08
#define LMP_RSSI_INQ 0x40
#define LMP_ESCO 0x80
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC 2/3] Bluetooth: Add HCI Coding Format definitions
2012-11-22 12:05 [RFC 0/3] Bluetooth: mgmt API for reading supported codecs Michael Knudsen
2012-11-22 12:05 ` [RFC 1/3] Bluetooth: Add HCI feature bit definition for transparent SCO Michael Knudsen
@ 2012-11-22 12:05 ` Michael Knudsen
2012-11-22 12:05 ` [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs Michael Knudsen
2 siblings, 0 replies; 6+ messages in thread
From: Michael Knudsen @ 2012-11-22 12:05 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Michael Knudsen
Add definitions for the codecs specified in CSA2.
---
include/net/bluetooth/hci.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 45ec1de..60505da 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -284,6 +284,15 @@ enum {
#define HCI_LM_RELIABLE 0x0010
#define HCI_LM_SECURE 0x0020
+/* Coding Format */
+#define HCI_FORMAT_ULAW 0x00
+#define HCI_FORMAT_ALAW 0x01
+#define HCI_FORMAT_CVSD 0x02
+#define HCI_FORMAT_TRANSPARENT 0x03
+#define HCI_FORMAT_PCM 0x04
+#define HCI_FORMAT_MSBC 0x05
+#define HCI_FORMAT_VENDOR 0xff
+
/* Authentication types */
#define HCI_AT_NO_BONDING 0x00
#define HCI_AT_NO_BONDING_MITM 0x01
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs
2012-11-22 12:05 [RFC 0/3] Bluetooth: mgmt API for reading supported codecs Michael Knudsen
2012-11-22 12:05 ` [RFC 1/3] Bluetooth: Add HCI feature bit definition for transparent SCO Michael Knudsen
2012-11-22 12:05 ` [RFC 2/3] Bluetooth: Add HCI Coding Format definitions Michael Knudsen
@ 2012-11-22 12:05 ` Michael Knudsen
2013-01-03 19:09 ` Gustavo Padovan
2 siblings, 1 reply; 6+ messages in thread
From: Michael Knudsen @ 2012-11-22 12:05 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Michael Knudsen
Provide an API for allowing user space to read the list of codecs
supported by a given controller. For now, hardwire PCM support,
but construct initial list of supported codecs by inspecting the
relevant bits of the local supported features bit mask. Later,
devices that support the appropriate HCI command will read out the
actual list during controller initialisation.
---
include/net/bluetooth/hci_core.h | 2 ++
include/net/bluetooth/mgmt.h | 7 +++++++
net/bluetooth/hci_core.c | 3 +++
net/bluetooth/hci_event.c | 21 +++++++++++++++++++++
net/bluetooth/mgmt.c | 36 ++++++++++++++++++++++++++++++++++++
5 files changed, 69 insertions(+)
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index ef5b85d..79fe128 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -153,6 +153,8 @@ struct hci_dev {
__u8 features[8];
__u8 host_features[8];
__u8 commands[64];
+ __u8 codecs;
+ __u8 codec[255];
__u8 hci_ver;
__u16 hci_rev;
__u8 lmp_ver;
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index 22980a7..523dc58 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -350,6 +350,13 @@ struct mgmt_cp_set_device_id {
} __packed;
#define MGMT_SET_DEVICE_ID_SIZE 8
+#define MGMT_OP_READ_CODECS 0x0029
+#define MGMT_READ_CODECS_SIZE 0
+struct mgmt_rp_read_codecs {
+ __u8 count;
+ __u8 codec[0];
+} __packed;
+
#define MGMT_EV_CMD_COMPLETE 0x0001
struct mgmt_ev_cmd_complete {
__le16 opcode;
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 81f4bac..9b0e974 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1708,6 +1708,9 @@ struct hci_dev *hci_alloc_dev(void)
hdev->sniff_max_interval = 800;
hdev->sniff_min_interval = 80;
+ hdev->codecs = 1;
+ hdev->codec[0] = HCI_FORMAT_PCM;
+
mutex_init(&hdev->lock);
mutex_init(&hdev->req_lock);
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 9f5c5f2..b110aaf 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -779,6 +779,27 @@ static void hci_cc_read_local_features(struct hci_dev *hdev,
if (hdev->features[5] & LMP_EDR_3S_ESCO)
hdev->esco_type |= (ESCO_2EV5 | ESCO_3EV5);
+ /* Initialise codec list */
+ if (hdev->features[1] & LMP_ULAW) {
+ hdev->codec[hdev->codecs] = HCI_FORMAT_ULAW;
+ hdev->codecs++;
+ }
+
+ if (hdev->features[1] & LMP_ALAW) {
+ hdev->codec[hdev->codecs] = HCI_FORMAT_ALAW;
+ hdev->codecs++;
+ }
+
+ if (hdev->features[2] & LMP_CVSD) {
+ hdev->codec[hdev->codecs] = HCI_FORMAT_CVSD;
+ hdev->codecs++;
+ }
+
+ if (hdev->features[2] & LMP_TRSP_SCO) {
+ hdev->codec[hdev->codecs] = HCI_FORMAT_TRANSPARENT;
+ hdev->codecs++;
+ }
+
BT_DBG("%s features 0x%.2x%.2x%.2x%.2x%.2x%.2x%.2x%.2x", hdev->name,
hdev->features[0], hdev->features[1],
hdev->features[2], hdev->features[3],
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index dedbb1d..a47fda2 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -76,6 +76,7 @@ static const u16 mgmt_commands[] = {
MGMT_OP_BLOCK_DEVICE,
MGMT_OP_UNBLOCK_DEVICE,
MGMT_OP_SET_DEVICE_ID,
+ MGMT_OP_READ_CODECS,
};
static const u16 mgmt_events[] = {
@@ -319,6 +320,40 @@ static int read_commands(struct sock *sk, struct hci_dev *hdev, void *data,
return err;
}
+static int read_codecs(struct sock *sk, struct hci_dev *hdev, void *data,
+ u16 len)
+{
+ struct mgmt_rp_read_codecs *rp;
+ int err;
+ size_t rp_size;
+
+ BT_DBG("sock %p %s", sk, hdev->name);
+
+ hci_dev_lock(hdev);
+
+ rp_size = sizeof(*rp) + hdev->codecs;
+
+ rp = kmalloc(rp_size, GFP_KERNEL);
+ if (!rp) {
+ hci_dev_unlock(hdev);
+ return -ENOMEM;
+ }
+
+ memset(rp, 0, sizeof(rp));
+
+ rp->count = hdev->codecs;
+ memcpy(rp->codec, hdev->codec, hdev->codecs);
+
+ hci_dev_unlock(hdev);
+
+ err = cmd_complete(sk, hdev->id, MGMT_OP_READ_CODECS, 0, rp,
+ rp_size);
+
+ kfree(rp);
+
+ return err;
+}
+
static int read_index_list(struct sock *sk, struct hci_dev *hdev, void *data,
u16 data_len)
{
@@ -2748,6 +2783,7 @@ static const struct mgmt_handler {
{ block_device, false, MGMT_BLOCK_DEVICE_SIZE },
{ unblock_device, false, MGMT_UNBLOCK_DEVICE_SIZE },
{ set_device_id, false, MGMT_SET_DEVICE_ID_SIZE },
+ { read_codecs, true, MGMT_READ_CODECS_SIZE },
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs
2012-11-22 12:05 ` [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs Michael Knudsen
@ 2013-01-03 19:09 ` Gustavo Padovan
2013-01-03 22:16 ` Vinicius Costa Gomes
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Padovan @ 2013-01-03 19:09 UTC (permalink / raw)
To: Michael Knudsen; +Cc: linux-bluetooth, Michael Knudsen
Hi Michael,
* Michael Knudsen <michaelknudsendk@gmail.com> [2012-11-22 13:05:08 +0100]:
> Provide an API for allowing user space to read the list of codecs
> supported by a given controller. For now, hardwire PCM support,
> but construct initial list of supported codecs by inspecting the
> relevant bits of the local supported features bit mask. Later,
> devices that support the appropriate HCI command will read out the
> actual list during controller initialisation.
> ---
> include/net/bluetooth/hci_core.h | 2 ++
> include/net/bluetooth/mgmt.h | 7 +++++++
> net/bluetooth/hci_core.c | 3 +++
> net/bluetooth/hci_event.c | 21 +++++++++++++++++++++
> net/bluetooth/mgmt.c | 36 ++++++++++++++++++++++++++++++++++++
> 5 files changed, 69 insertions(+)
>
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index ef5b85d..79fe128 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -153,6 +153,8 @@ struct hci_dev {
> __u8 features[8];
> __u8 host_features[8];
> __u8 commands[64];
> + __u8 codecs;
> + __u8 codec[255];
> __u8 hci_ver;
> __u16 hci_rev;
> __u8 lmp_ver;
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index 22980a7..523dc58 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -350,6 +350,13 @@ struct mgmt_cp_set_device_id {
> } __packed;
> #define MGMT_SET_DEVICE_ID_SIZE 8
>
> +#define MGMT_OP_READ_CODECS 0x0029
> +#define MGMT_READ_CODECS_SIZE 0
> +struct mgmt_rp_read_codecs {
> + __u8 count;
> + __u8 codec[0];
> +} __packed;
> +
We think it is better to read the list of codecs from the SCO socket, we need
to allow both oFono and PulseAudio to read them without the need of talking to
BlueZ. Also, bluetoothd has nothing intersting to do with this information.
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs
2013-01-03 19:09 ` Gustavo Padovan
@ 2013-01-03 22:16 ` Vinicius Costa Gomes
0 siblings, 0 replies; 6+ messages in thread
From: Vinicius Costa Gomes @ 2013-01-03 22:16 UTC (permalink / raw)
To: Gustavo Padovan, Michael Knudsen, linux-bluetooth,
Michael Knudsen
Hi Gustavo,
>
> We think it is better to read the list of codecs from the SCO socket, we need
> to allow both oFono and PulseAudio to read them without the need of talking to
> BlueZ. Also, bluetoothd has nothing intersting to do with this information.
Take a look at the thread "CSA2: User space aspect"[1]. I have to agree
with Marcel, the mgmt command makes more sense. As how that information
will get to oFono/PulseAudio we have NewConnection() in the Profile API
and SetConfiguration() on the Media API, that may be extended (if
needed).
>
> Gustavo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
--
Vinicius
[1] http://thread.gmane.org/gmane.linux.bluez.kernel/31746
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-03 22:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-22 12:05 [RFC 0/3] Bluetooth: mgmt API for reading supported codecs Michael Knudsen
2012-11-22 12:05 ` [RFC 1/3] Bluetooth: Add HCI feature bit definition for transparent SCO Michael Knudsen
2012-11-22 12:05 ` [RFC 2/3] Bluetooth: Add HCI Coding Format definitions Michael Knudsen
2012-11-22 12:05 ` [RFC 3/3] Bluetooth: Provide mgmt API for reading list of supported codecs Michael Knudsen
2013-01-03 19:09 ` Gustavo Padovan
2013-01-03 22:16 ` Vinicius Costa Gomes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).