Re: [PATCH BlueZ 2/2] avctp: Receive and silent ignore Vol Up/Down operations

[Vinicius Costa Gomes <vinicius.gomes@openbossa.org>]

Hi Joao,

On 15:18 Tue 22 Jan, João Paulo Rechi Vita wrote:
> The AVRCP spec mandates to support 'volume up' and 'volume down'
> operations when claiming support for Category 2 TG.
> ---
>  profiles/audio/avctp.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
> index f7e607e..4ab6d6d 100644
> --- a/profiles/audio/avctp.c
> +++ b/profiles/audio/avctp.c
> @@ -214,6 +214,8 @@ static struct {
>  	uint8_t avc;
>  	uint16_t uinput;
>  } key_map[] = {
> +	{ "VOLUME UP",		AVC_VOLUME_UP,		KEY_VOLUMEUP},
> +	{ "VOLUME DOWN",	AVC_VOLUME_DOWN,	KEY_VOLUMEDOWN},
>  	{ "PLAY",		AVC_PLAY,		KEY_PLAYCD },
>  	{ "STOP",		AVC_STOP,		KEY_STOPCD },
>  	{ "PAUSE",		AVC_PAUSE,		KEY_PAUSECD },
> @@ -968,6 +970,9 @@ static void init_uinput(struct avctp *session)
>  
>  	dev = manager_get_audio_device(session->device, FALSE);
>  
> +	session->key_quirks[AVC_VOLUME_UP] |= QUIRK_IGNORE;
> +	session->key_quirks[AVC_VOLUME_DOWN] |= QUIRK_IGNORE;
> +

Having a quirk that applies to every device, doesn't seem to map to the
meaning of 'quirk', i.e. if everybody has the same quirk, it is the norm ;-)


Cheers,
-- 
Vinicius