From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 6/6] gas: Move all the code to only one file
Date: Fri, 25 Jan 2013 09:36:36 +0200 [thread overview]
Message-ID: <20130125073636.GB19244@x220> (raw)
In-Reply-To: <1359083227-13122-7-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Fri, Jan 25, 2013, Vinicius Costa Gomes wrote:
> Our Generic Attribute/Access Service plugin is small and simple enough
> to be kept in only one file.
> ---
> Makefile.plugins | 4 +--
> profiles/gatt/gas.c | 46 ++++++++++++++++++++++++++++
> profiles/gatt/main.c | 47 -----------------------------
> profiles/gatt/manager.c | 79 -------------------------------------------------
> profiles/gatt/manager.h | 24 ---------------
> 5 files changed, 47 insertions(+), 153 deletions(-)
> delete mode 100644 profiles/gatt/main.c
> delete mode 100644 profiles/gatt/manager.c
> delete mode 100644 profiles/gatt/manager.h
>
> diff --git a/Makefile.plugins b/Makefile.plugins
> index faab011..f497782 100644
> --- a/Makefile.plugins
> +++ b/Makefile.plugins
> @@ -69,9 +69,7 @@ builtin_sources += profiles/health/mcap_lib.h profiles/health/mcap_internal.h \
> endif
>
> builtin_modules += gatt
> -builtin_sources += profiles/gatt/main.c profiles/gatt/manager.h \
> - profiles/gatt/manager.c profiles/gatt/gas.h \
> - profiles/gatt/gas.c
> +builtin_sources += profiles/gatt/gas.c
You seem to have forgotten to remove gas.h in this patch. You remove it
from Makefile.plugins but it's still in the tree and gas.c includes it.
You'll also want to make gas_register/unregister static together with
removing the header file.
Johan
next prev parent reply other threads:[~2013-01-25 7:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 3:07 [RFC BlueZ 0/6] LE Connection Establishment fixes Vinicius Costa Gomes
2013-01-25 3:07 ` [RFC BlueZ 1/6] device: Fix invalid memory access during Find Included Vinicius Costa Gomes
2013-01-25 7:07 ` Johan Hedberg
2013-01-25 3:07 ` [RFC BlueZ 2/6] device: Fix memory leak while storing GATT capable devices Vinicius Costa Gomes
2013-01-25 7:08 ` Johan Hedberg
2013-01-25 3:07 ` [RFC BlueZ 3/6] device: Clean up device_att_connect() Vinicius Costa Gomes
2013-01-25 3:07 ` [RFC BlueZ 4/6] device: Rename device_att_connect to device_connect_le Vinicius Costa Gomes
2013-01-25 7:32 ` Johan Hedberg
2013-01-25 3:07 ` [RFC BlueZ 5/6] core: Add a way to connect to LE devices Vinicius Costa Gomes
2013-01-25 3:07 ` [RFC BlueZ 6/6] gas: Move all the code to only one file Vinicius Costa Gomes
2013-01-25 7:36 ` Johan Hedberg [this message]
2013-01-25 10:55 ` Anderson Lizardo
2013-01-25 7:12 ` [RFC BlueZ 0/6] LE Connection Establishment fixes Johan Hedberg
2013-01-25 9:55 ` Johan Hedberg
2013-01-25 11:30 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125073636.GB19244@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).