From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
Subject: Re: [PATCH 09/14] neard: Use path instead of boolean to track if registered to neard
Date: Fri, 15 Feb 2013 10:46:00 +0200 [thread overview]
Message-ID: <20130215084600.GB5750@x220> (raw)
In-Reply-To: <1360224844-12280-10-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
On Thu, Feb 07, 2013, Szymon Janc wrote:
> ---
> plugins/neard.c | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
Patches 1-8 have been applied but this one had something that imo needs
fixing:
> -static gboolean agent_registered = FALSE;
> +static char *neard_path = NULL;
> static gboolean agent_register_postpone = FALSE;
>
> /* For NFC mimetype limits max OOB EIR size */
> @@ -115,7 +115,7 @@ static void register_agent_cb(DBusPendingCall *call, void *user_data)
> }
>
> dbus_message_unref(reply);
> - agent_registered = TRUE;
> + neard_path = g_strdup(dbus_message_get_sender(reply));
If you're going to store the neard D-Bus name in this variable then
please don't call it "path". That's just confusing. Use neard_name or
neard_service instead.
Johan
next prev parent reply other threads:[~2013-02-15 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 8:13 [PATCH 00/14] neard plugin update Szymon Janc
2013-02-07 8:13 ` [PATCH 01/14] neard: Adjust errors to latest API changes Szymon Janc
2013-02-07 8:13 ` [PATCH 02/14] neard: Refactor message processing Szymon Janc
2013-02-07 8:13 ` [PATCH 03/14] neard: Add ability to parse 'State' field Szymon Janc
2013-02-07 8:13 ` [PATCH 04/14] neard: Move pairable check from check_adapter Szymon Janc
2013-02-07 8:13 ` [PATCH 05/14] adapter: Add btd_adapter_get_powered function Szymon Janc
2013-02-07 8:13 ` [PATCH 06/14] neard: Check if adapter is powered in PushOOB Szymon Janc
2013-02-07 8:13 ` [PATCH 07/14] adapter: Add btd_adapter_get_connectable function Szymon Janc
2013-02-07 8:13 ` [PATCH 08/14] neard: Add support for setting power state in RequestOOB reply Szymon Janc
2013-02-07 8:13 ` [PATCH 09/14] neard: Use path instead of boolean to track if registered to neard Szymon Janc
2013-02-15 8:46 ` Johan Hedberg [this message]
2013-02-07 8:14 ` [PATCH 10/14] neard: Restrict method calls only to neard process Szymon Janc
2013-02-07 8:14 ` [PATCH 11/14] neard: Use bool instead of gboolean for agent_register_postpone Szymon Janc
2013-02-07 8:14 ` [PATCH 12/14] neard: Update copyright information Szymon Janc
2013-02-07 8:14 ` [PATCH 13/14] neard: Updated neard handover registration agent api calls Szymon Janc
2013-02-07 8:14 ` [PATCH 14/14] neard: Add fallback to legacy register if register failed Szymon Janc
2013-02-11 9:52 ` [PATCH 00/14] neard plugin update Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215084600.GB5750@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ravikumar.veeramally@linux.intel.com \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox