linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] bloodpressure: Add Blood Pressure API
Date: Wed, 20 Feb 2013 09:57:25 +0200	[thread overview]
Message-ID: <20130220075725.GA14731@x220> (raw)
In-Reply-To: <1360668097-28906-1-git-send-email-waldemar.rymarkiewicz@tieto.com>

Hi Waldek,

On Tue, Feb 12, 2013, Waldemar Rymarkiewicz wrote:
> Change-Id: I7165ecee0186dfdb51cd01838f28768d94ff12b9
> ---

Please provide a proper commit message.

> +Blood Pressure Manager hierarchy
> +================================
> +
> +Serviceorg.bluez
> +Interface	org.bluez.BloodPressureManager1
> +Object path	[variable prefix]/{hci0,hci1,...}
> +
> +Methods		RegisterWatcher(object agent)
> +
> +			Registers a watcher to monitor blood pressure
> +			measurements. This agent will be notified about
> +			final pressure measurements.
> +
> +			Possible Errors: org.bluez.Error.InvalidArguments
> +
> +		UnregisterWatcher(object agent)
> +
> +			Unregisters a watcher.
> +
> +		EnableIntermediateMeasurement(object agent)
> +
> +			Enables intermediate measurement notifications
> +			for this agent. Intermediate measurements will
> +			be enabled only for devices which support it.
> +
> +			Possible Errors: org.bluez.Error.InvalidArguments
> +
> +		DisableIntermediateMeasurement(object agent)
> +
> +			Disables intermediate measurement notifications
> +			for this agent. It will disable notifications in
> +			devices when the last agent removes the
> +			watcher for intermediate measurements.
> +
> +			Possible Errors: org.bluez.Error.InvalidArguments
> +					org.bluez.Error.NotFound

I'm a bit confused, what's the difference between "watcher" and "agent"?
If they're the same thing just pick one term and stick to it.

> +Blood Pressure Profile hierarchy
> +================================
> +
> +Service		org.bluez
> +Interface	org.bluez.BloodPressure1
> +Object path	[variable prefix]/{hci0,hci1,...}/dev_XX_XX_XX_XX_XX_XX
> +
> +Properties	boolean Intermediate [readonly]
> +
> +			True if the device supports intermediate
> +			measurement notifications.

What's the use of this property (and the interface)? I don't see how it
relates to any other APIs in this specification.

Johan

  reply	other threads:[~2013-02-20  7:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 11:21 [RFC] bloodpressure: Add Blood Pressure API Waldemar Rymarkiewicz
2013-02-20  7:57 ` Johan Hedberg [this message]
2013-02-28 14:00   ` Rymarkiewicz Waldemar
2013-02-28 14:18     ` Johan Hedberg
2013-03-01  8:34       ` Rymarkiewicz Waldemar
2013-03-01  8:39         ` Johan Hedberg
2013-03-01 12:11       ` Rymarkiewicz Waldemar
2013-03-01 13:37         ` Johan Hedberg
2013-03-02  3:09 ` Marcel Holtmann
2013-03-05 11:39   ` Rymarkiewicz Waldemar
2013-03-05 16:15     ` Marcel Holtmann
2013-03-06  8:51       ` Rymarkiewicz Waldemar
2013-03-13  6:51         ` Rymarkiewicz Waldemar
2013-05-08  7:41           ` Johan Hedberg
2013-05-16 12:17             ` Waldemar Rymarkiewicz
2013-05-16 12:22               ` Waldemar Rymarkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130220075725.GA14731@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=waldemar.rymarkiewicz@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).