From: Gustavo Padovan <gustavo@padovan.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 00/11] Bluetooth: Add asynchronous request support
Date: Tue, 5 Mar 2013 20:15:24 -0300 [thread overview]
Message-ID: <20130305231524.GA9738@joana> (raw)
In-Reply-To: <C36CBB88-DD0E-41AC-96C6-2A5A63D68F18@holtmann.org>
Hi Johan,
* Marcel Holtmann <marcel@holtmann.org> [2013-03-05 11:31:38 -0800]:
> Hi Johan,
>
> > Here's a v3 of the patch set with Marcel's feedback taken into account.
> >
> > Johan
> >
> > ----------------------------------------------------------------
> > Johan Hedberg (11):
> > Bluetooth: Rename hci_request to hci_req_sync
> > Bluetooth: Fix __hci_request() handling of empty requests
> > Bluetooth: Split HCI init sequence into three stages
> > Bluetooth: Add initial skeleton for asynchronous HCI requests
> > Bluetooth: Refactor HCI command skb creation
> > Bluetooth: Introduce new hci_req_add function
> > Bluetooth: Fix stand-alone HCI command handling
> > Bluetooth: Add request cmd_complete and cmd_status functions
> > Bluetooth: Use async requests internally in hci_req_sync
> > Bluetooth: Remove unused hdev->init_last_cmd
> > Bluetooth: Remove empty HCI event handlers
> >
> > include/net/bluetooth/bluetooth.h | 10 +
> > include/net/bluetooth/hci_core.h | 15 +-
> > net/bluetooth/hci_core.c | 668 +++++++++++++++++++++++++++++++------
> > net/bluetooth/hci_event.c | 504 +---------------------------
> > net/bluetooth/hci_sock.c | 5 +
> > 5 files changed, 603 insertions(+), 599 deletions(-)
>
> I am fine with this patch set now.
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
>
> It would be still good if someone else does a sanity read through and extra testing with this patch set before we push it into bluetooth-next.
It looked pretty good to me and since we got positive testing feedback from
Andre I've gone ahead and pushed all patches to bluetooth-next. Thanks.
Gustavo
prev parent reply other threads:[~2013-03-05 23:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 18:37 [PATCH v3 00/11] Bluetooth: Add asynchronous request support Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 01/11] Bluetooth: Rename hci_request to hci_req_sync Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 02/11] Bluetooth: Fix __hci_request() handling of empty requests Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 03/11] Bluetooth: Split HCI init sequence into three stages Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 04/11] Bluetooth: Add initial skeleton for asynchronous HCI requests Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 05/11] Bluetooth: Refactor HCI command skb creation Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 06/11] Bluetooth: Introduce new hci_req_add function Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 07/11] Bluetooth: Fix stand-alone HCI command handling Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 08/11] Bluetooth: Add request cmd_complete and cmd_status functions Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 09/11] Bluetooth: Use async requests internally in hci_req_sync Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 10/11] Bluetooth: Remove unused hdev->init_last_cmd Johan Hedberg
2013-03-05 18:37 ` [PATCH v3 11/11] Bluetooth: Remove empty HCI event handlers Johan Hedberg
2013-03-05 19:31 ` [PATCH v3 00/11] Bluetooth: Add asynchronous request support Marcel Holtmann
2013-03-05 20:04 ` Andre Guedes
2013-03-05 23:15 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305231524.GA9738@joana \
--to=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox