From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 3/3] core: Add DisableProfiles entry to main.conf
Date: Thu, 7 Mar 2013 09:23:12 +0200 [thread overview]
Message-ID: <20130307072312.GA28996@x220> (raw)
In-Reply-To: <1362566668-5098-3-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Wed, Mar 06, 2013, Luiz Augusto von Dentz wrote:
> int btd_profile_register(struct btd_profile *profile)
> {
> + int i;
> +
> + if (blacklist == NULL)
> + goto done;
> +
> + for (i = 0; blacklist[i]; i++) {
> + if (g_pattern_match_simple(blacklist[i], profile->name))
> + return -EPROTONOSUPPORT;
> +
> + if (profile->local_uuid != NULL && strcasecmp(blacklist[i],
> + profile->local_uuid) == 0)
> + return -EPROTONOSUPPORT;
> +
> + if (profile->remote_uuids == NULL)
> + continue;
> +
> + if (strcasecmp(blacklist[i], profile->remote_uuids[0]) == 0)
> + return -EPROTONOSUPPORT;
> + }
Since this is matching both local and remote UUID it seems like it
wouldn't be possible to just disable one role of an asymmetric profile
(like HFP) since no matter which role's UUID you give it'd always match
both roles.
Johan
prev parent reply other threads:[~2013-03-07 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 10:44 [PATCH BlueZ 1/3] audio: Remove profile enabling/disabling logic Luiz Augusto von Dentz
2013-03-06 10:44 ` [PATCH BlueZ 2/3] audio: Fix not using opposite role for local servers Luiz Augusto von Dentz
2013-03-06 10:44 ` [PATCH BlueZ 3/3] core: Add DisableProfiles entry to main.conf Luiz Augusto von Dentz
2013-03-07 7:23 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307072312.GA28996@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).