From: Gustavo Padovan <gustavo@padovan.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix endianness handling of cmd_status/complete opcodes
Date: Sat, 9 Mar 2013 17:20:19 -0300 [thread overview]
Message-ID: <20130309202019.GB9938@joana> (raw)
In-Reply-To: <1362815630-6800-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
* Johan Hedberg <johan.hedberg@gmail.com> [2013-03-09 09:53:50 +0200]:
> From: Johan Hedberg <johan.hedberg@intel.com>
>
> The opcode in cmd_complete and cmd_status events is 16 bits, so we
> should only be comparing it after having converted it to the host
> endianness. There's already an opcode variable in both functions which
> is in host endiannes so the right fix is to just start using it instead
> of ev->opcode.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> net/bluetooth/hci_event.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
prev parent reply other threads:[~2013-03-09 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 7:53 [PATCH] Bluetooth: Fix endianness handling of cmd_status/complete opcodes Johan Hedberg
2013-03-09 20:20 ` Gustavo Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309202019.GB9938@joana \
--to=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox