Re: [PATCH 3/6] "agent" command capability argument and autocompletion

[Vinicius Costa Gomes <vinicius.gomes@openbossa.org>]

Hi Alex,

Sorry for the double post.

On 11:22 Thu 14 Mar, Alex Deymo wrote:
> This patch enables argument autocompletion for the agent command with the
> list of capabilities an agent can have, adding also "on" (for the default "")
> and "off". The command passes the argument (parsing and verifying it) to the
> dbus method call.
> ---
>  client/main.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 79 insertions(+), 3 deletions(-)
> 
> diff --git a/client/main.c b/client/main.c
> index 704cf46..12b08b5 100644
> --- a/client/main.c
> +++ b/client/main.c
> @@ -59,6 +59,27 @@ static GDBusProxy *default_ctrl;
>  static GList *ctrl_list;
>  static GList *dev_list;
>  
> +static const char* agent_arguments[] = {
> +	"on",
> +	"off",
> +	"DisplayOnly",
> +	"DisplayYesNo",
> +	"KeyboardDisplay",
> +	"KeyboardOnly",
> +	"NoInputNoOutput",
> +	NULL
> +};
> +
> +static const char* agent_capability_options[] = {

Neither I (nor my compiler) could find any usages of this ;-)

> +	"", /* default */
> +	"DisplayOnly",
> +	"DisplayYesNo",
> +	"KeyboardDisplay",
> +	"KeyboardOnly",
> +	"NoInputNoOutput",
> +	NULL
> +};
> +

[snip]


Cheers,
-- 
Vinicius