From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] audio: Track connections to AVRCP roles separately
Date: Fri, 15 Mar 2013 12:25:57 -0500 [thread overview]
Message-ID: <20130315172557.GA13970@x220> (raw)
In-Reply-To: <1363365990-1901-1-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Fri, Mar 15, 2013, Luiz Augusto von Dentz wrote:
> -void audio_control_connected(struct btd_device *dev, int err);
> -void audio_control_disconnected(struct btd_device *dev, int err);
> +void audio_target_connected(struct btd_device *dev, int err);
> +void audio_target_disconnected(struct btd_device *dev, int err);
> +void audio_remote_connected(struct btd_device *dev, int err);
> +void audio_remote_disconnected(struct btd_device *dev, int err);
Otherwise the patch looks ok'ish but the term "remote" is a bit
confusing to me since I immediately think about "remote device". Would
"controller" or simply "ct" and "tg" be better?
Johan
prev parent reply other threads:[~2013-03-15 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 16:46 [PATCH BlueZ] audio: Track connections to AVRCP roles separately Luiz Augusto von Dentz
2013-03-15 17:25 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315172557.GA13970@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox